Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All typing users are displayed above the text box when many people are typing #8722

Closed
daitasu opened this issue Oct 31, 2017 · 0 comments · Fixed by #12400
Closed

All typing users are displayed above the text box when many people are typing #8722

daitasu opened this issue Oct 31, 2017 · 0 comments · Fixed by #12400

Comments

@daitasu
Copy link

daitasu commented Oct 31, 2017

Description:

I checked the code of packages/rocketchat-ui-message/client/messageBox.js
The usersTyping() methods in this file shows :

let last = users.pop();
if (users.length > 4) {
    last = t('others');
}
let usernames = users.join(', ');
usernames = [usernames, last];
return {
    multi: true,
    selfTyping: MsgTyping.selfTyping.get(),
    users: usernames.join(` ${ t('and') } `)
};

This code means displaying username is typing... when some users is typing above the text box.
It displays username1 is typing when a person is typing and it also displays username1, username2 and username3 are typing when 3 persons is typing.
However, I'm wondering if this code is better in the case that many people is typing because this code use pop() methods only 1 time.
This code maybe indicate that only the name of last person change to others therefore it is caused that displaying like username1, username2, ..., username99 and others are typing when many people like a hundreds are typing.

Server Setup Information:

  • Operating System: CentOS 7
  • Deployment Method(snap/docker/tar/etc): from source
  • Number of Running Instances: 1
  • Node Version: 4

Steps to Reproduce:

  1. some people more than 5 persons open RocketChat and join same room.
  2. all of them in the room type the message in the same time.

Expected behavior:

The word of username1, username2 and others are typing... is displayed.

Actual behavior:

The word of username1, username2, username3, username4 and others are typing... is displayed in the case that 5 persons are typing.

@ggazzo ggazzo added the ui/ux label Oct 18, 2018
@ggazzo ggazzo added this to To do in November/2018 via automation Oct 18, 2018
@ggazzo ggazzo added this to the 0.72.0 milestone Oct 18, 2018
vinade added a commit to vinade/Rocket.Chat that referenced this issue Oct 24, 2018
It limits the number of usernames shown above the textbox when people
are typing.

If the number of typing users isn't greater than 4, then the text will
show all usernames:
`username1, username2, username3 and username4 are typing`

But, if the number of typing users is greater than 4, then the last
username will be replaced by `others`, like this:
`username1, username2, username3 and others are typing`

The number 4 was chosen because it was already in the code
vinade added a commit to vinade/Rocket.Chat that referenced this issue Oct 24, 2018
It limits the number of usernames shown above the textbox when people
are typing.

If the number of typing users isn't greater than 4, then the text will
show all usernames:
`username1, username2, username3 and username4 are typing`

But, if the number of typing users is greater than 4, then the last
username will be replaced by `others`, like this:
`username1, username2, username3 and others are typing`

The number 4 was chosen because it was already in the code
November/2018 automation moved this from To do to Done Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
November/2018
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants