Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Missing sidebar default options on admin #10016

Merged
merged 4 commits into from
Mar 15, 2018

Conversation

karlprieb
Copy link
Contributor

@RocketChat/core

Closes #9941

I also removed the old view mode setting that we used to have on our messages box, this setting is not used anymore and can be confused with sidebar view mode.

image

image

image

@karlprieb karlprieb added this to the 0.63.0 milestone Mar 6, 2018
@karlprieb karlprieb added this to Desireable in 0.63.0 via automation Mar 6, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10016 March 6, 2018 01:55 Inactive
@karlprieb karlprieb moved this from Desireable to Review/QA in 0.63.0 Mar 6, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10016 March 7, 2018 19:18 Inactive
},
{
key: 'condensed',
i18nLabel: 'Extended'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong label

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10016 March 7, 2018 20:28 Inactive
@rodrigok rodrigok changed the title [FIX] add sidebar default options on admin and fix admin/user settings sidebar items [FIX] Missing sidebar default options on admin Mar 15, 2018
@rodrigok rodrigok merged commit 5d58203 into develop Mar 15, 2018
0.63.0 automation moved this from Review/QA to Done Mar 15, 2018
@rodrigok rodrigok deleted the sidebar-viewmode-admin-option branch March 15, 2018 19:29
@johnyb0y
Copy link

Thanks @karlprieb. Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
0.63.0
  
Done
Development

Successfully merging this pull request may close these issues.

Create admin-settings for the new view settings in the sidebar
4 participants