[NEW] search only default tone emoji Popup search #10017
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #9898
Currently the pop up emoji search can get clogged with tonal versions of the same emoji
![36672566-05e7fd4c-1b00-11e8-983d-7ec260c24a05](https://user-images.githubusercontent.com/24814085/37011593-168160b8-20ae-11e8-9a13-4b57b6bb17d5.png)
In this PR i propose to exclude Tonal versions of emojis from popUp until the user begins to explicitly request them
![newhand](https://user-images.githubusercontent.com/24814085/37011771-da897ed2-20ae-11e8-9782-d44ecd36a8c8.png)
This code will hides tones as shown above until the user begins typing _t (and keeps them shown through typing _tone[1-5]: as below
![handballtones](https://user-images.githubusercontent.com/24814085/37011815-0c842a22-20af-11e8-8e7b-bc35b2187fc8.png)
While not the suggested fix, perhaps this functionality is true to the intent, this way one retains full emoji power and a more powerful search, without taking the hands off the keyboard.