Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Changes all 'mergeChannels' to 'groupByType'. #10055

Merged
merged 2 commits into from
May 30, 2018
Merged

[NEW] Changes all 'mergeChannels' to 'groupByType'. #10055

merged 2 commits into from
May 30, 2018

Conversation

mikaelmello
Copy link
Contributor

Modifies boolean logic as necessary.

It keeps logic reported on #10042 even though I still don't understand it yet.

This PR was made because there were comments with a TODO to do this exact change.

@RocketChat/core

https://github.com/RocketChat/docs/pull/621

Modifies boolean logic as necessary.
@CLAassistant
Copy link

CLAassistant commented Mar 8, 2018

CLA assistant check
All committers have signed the CLA.

@rodrigok rodrigok requested a review from a team March 8, 2018 21:14
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikaelmello shoud we create a migration? what do you think?

@mikaelmello
Copy link
Contributor Author

@ggazzo Yeah probably. If we don't though, the only impact was that this setting is specific would be kind of "reset", is that correct?

@ggazzo
Copy link
Member

ggazzo commented May 26, 2018

something like that, but old servers will keep this useless data forever, and probably some users will complain about loose configs... if you need some help to create a migration I can help :)

@ggazzo
Copy link
Member

ggazzo commented May 30, 2018

@mikaelmello I cant checkout your branch could you add this migration?

RocketChat.Migrations.add({
	version: 122,
	up() {
		return RocketChat.models.Users.update({
			'settings.preferences.mergeChannels': {
				$exists: true
			}
		}, {
			$rename: {
				'settings.preferences.mergeChannels': 'settings.preferences.groupByType'
			}
		}, {
			multi: true
		});
	}
});

@ggazzo ggazzo changed the base branch from develop to groupByType May 30, 2018 17:16
@ggazzo ggazzo merged commit 2837942 into RocketChat:groupByType May 30, 2018
@engelgabriel engelgabriel added this to Desireable in June/2018 via automation Jun 4, 2018
@engelgabriel engelgabriel added this to the 0.66.0 milestone Jun 4, 2018
@ggazzo ggazzo moved this from Desireable to Closed in June/2018 Jun 11, 2018
@rodrigok rodrigok mentioned this pull request Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
June/2018
  
Closed
Development

Successfully merging this pull request may close these issues.

None yet

5 participants