Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] GitLab authentication scope was too open, reduced to read only access #10225

Merged
merged 3 commits into from
Apr 17, 2018

Conversation

rafaelks
Copy link
Contributor

This change was discussed internally.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10225 March 26, 2018 21:35 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10225 March 31, 2018 21:40 Inactive
@sampaiodiego sampaiodiego added this to the 0.64.0 milestone Apr 16, 2018
@sampaiodiego sampaiodiego added this to Desireable in 0.64.0 via automation Apr 16, 2018
@theorenck theorenck moved this from Desireable to Review/QA in 0.64.0 Apr 17, 2018
@rodrigok rodrigok changed the title [FIX] Change GitLab scope from API to read_user, so we only have read access [FIX] GitLab authentication scope was too open, reduced to read only access Apr 17, 2018
@rodrigok rodrigok merged commit 2de1530 into develop Apr 17, 2018
0.64.0 automation moved this from Review/QA to Done Apr 17, 2018
@rodrigok rodrigok deleted the fix/request_only_read_permissions_gitlab branch April 17, 2018 17:36
@theorenck theorenck moved this from Done to Review/QA in 0.64.0 Apr 17, 2018
@theorenck theorenck moved this from Review/QA to Done in 0.64.0 Apr 17, 2018
@rodrigok rodrigok mentioned this pull request Apr 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
0.64.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants