Fix: Renaming channels.notifications Get/Post endpoints #10257
Conversation
…etOne and rooms.saveNotifications
| @@ -25,6 +25,28 @@ RocketChat.API.v1.addRoute('subscriptions.get', { authRequired: true }, { | |||
| } | |||
| }); | |||
|
|
|||
| RocketChat.API.v1.addRoute('subscriptions.getOne', { authRequired: true }, { | |||
There was a problem hiding this comment.
I know this is just for renaming endpoints, but since I was not able to comment on the old PR I'll do it now =)
what is the difference between subscriptions.getOne and subscriptions.get? IMO they should be the same accepting different queries.
There was a problem hiding this comment.
One calls the method and one calls directly from the database. I haven't had a chance to look into what exactly that method does, so no clue if there is a difference.
There was a problem hiding this comment.
@sampaiodiego sadly, I'm going to have to say that we should keep the calls separated. The main reason for this is because the subscriptions.get returns an object with two properties that are arrays. If we switch to allow support for getting only one, either we would have to change the response format for it to make sense or use the current format which doesn't make sense when returning/getting only one. So, keeping the subscriptions.getOne makes sense for the data being returned. What's your thoughts?
There was a problem hiding this comment.
yep.. I've tested this and saw the payload differences as well.. 😞 agreed keeping both separated
|
@sampaiodiego @rodrigok Just added to milestone 0.63... let me know if you guys can make it please. |
rodrigok
changed the title
Renaming channels.notifications Get/Post endpoints to
subscriptions.getOneandrooms.saveNotifications.