[FIX] File had redirect delay when using external storage services and no option to proxy only avatars #10272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampaiodiego
previously requested changes
Mar 29, 2018
| @@ -10,10 +10,12 @@ const get = function(file, req, res) { | |||
| const fileUrl = this.store.getRedirectURL(file); | |||
|
|
|||
| if (fileUrl) { | |||
| if (RocketChat.settings.get('FileUpload_S3_Proxy')) { | |||
| const storeTyoe = file.store.split(':').pop(); | |||
…d no option to proxy only avatars
rodrigok
force-pushed
the
hotfix/avatar-cache
branch
from
bc06e77
to
dd092f9
Compare
geekgonecrazy
approved these changes
Mar 29, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.