[NEW] REST API endpoint /directory
#10442
Conversation
| }); | ||
| }); | ||
|
|
||
| describe('/settings.oauth', () => { |
There was a problem hiding this comment.
Shouldn't this be moved to the settings one and not the miscellaneous one? 🤔
There was a problem hiding this comment.
oops.. looks it's duplicated of this one.
@MarcosSpessatto can you please remove this test from here?
| }); | ||
| }); | ||
|
|
||
| describe('/settings.oauth', () => { |
There was a problem hiding this comment.
oops.. looks it's duplicated of this one.
@MarcosSpessatto can you please remove this test from here?
| limit: count | ||
| })); | ||
|
|
||
| if (result) { |
There was a problem hiding this comment.
I think as a good practice, the unexpected condition should be treated specially and not the successful one.
so I will ask you to change this here, so the if will trigger the failure.
geekgonecrazy
dismissed
sampaiodiego’s stale review
looks like addressed feedback
rodrigok
changed the title
/directory
|
@rodrigok did you test this yourself? We were investigating an issue with the rest API not working on the deployed heroku instance. |
|
@graywolf336 the last instance I tried on heroku was built based on |
|
Well it had the |
Add REST /directory endpoint.
Closes #9961.