Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Integrations with room data not having the usernames filled in #10576

Merged
merged 2 commits into from
Apr 26, 2018
Merged

[FIX] Integrations with room data not having the usernames filled in #10576

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57f7d7c
Fix integrations with room data not having the usernames filled in
graywolf336 Apr 24, 2018
63805b5
Change _.clone object spread
sampaiodiego Apr 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/rocketchat-integrations/server/lib/triggerHandler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ RocketChat.integrations.triggerHandler = new class RocketChatIntegrationHandler
}

if (data) {
history.data = data;
history.data = { ...data };
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly, this does not work as you expect it to work. So, we need to revert this change:
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@graywolf336 the _clone doesn't do the same? Copying only the first level of the object?


if (data.user) {
history.data.user = _.omit(data.user, ['meta', '$loki', 'services']);
Expand Down