[FIX] Livechat user registration in another department #10695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eing displayed because there is no subscription for the manager.
…m and it was a registered user, if they tried to register in a different department from the previous department, this was not taking effect and the user was being sent to the same department registered before.
ggazzo
reviewed
Jun 14, 2018
…cketChat/Rocket.Chat into livechat-user-registration-department
# Conflicts: # packages/rocketchat-livechat/.app/client/lib/chatMessages.js # packages/rocketchat-livechat/.app/client/views/register.js # packages/rocketchat-livechat/.app/imports/client/visitor.js # packages/rocketchat-livechat/server/methods/registerGuest.js
# Conflicts: # packages/rocketchat-livechat/.app/client/views/register.js
|
@renatobecker I guess this is still valid right? if so, can you please fix the conflicts? thanks |
# Conflicts: # packages/rocketchat-livechat/.app/client/views/register.js # packages/rocketchat-livechat/server/lib/Livechat.js # packages/rocketchat-livechat/server/methods/registerGuest.js
|
@sampaiodiego, done! |
sampaiodiego
requested changes
Apr 11, 2019
sampaiodiego
approved these changes
Apr 11, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7398
This PR adds a verification when a registered visitor attempted to register with a different department that they previously registered. If a registered visitor tried to register in another department, it was being sent to the same department / agent and is not a correct behavior.