[FIX] adds support for multiple ECDH curves #11016
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aramix is this still valid? |
@geekgonecrazy yes if the node version on server is < v8.6.0 |
|
The semver check should target < The |
|
Unfortunately this PR is so old that this PR is no longer mergeable as is. I believe the file has been moved and likely renamed during a reorg pre 1.0 |
| // https://github.com/nodejs/node/pull/16853 | ||
| // This is fixed in Node 10, but this woraround also supports LTS versions | ||
| // https://github.com/nodejs/node/pull/15206 | ||
| if (semver.gte(process.version, '8.6.0') && tls.DEFAULT_ECDH_CURVE === 'prime256v1') { |
There was a problem hiding this comment.
we don't need to test nodejs version, as we run only on 8.11.4 .. once we upgrade to a higher Node version, we can remove this code completely (from my understanding on code the comments)
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9669
Closing this with a fix as there was no support for versions of NodeJS < v8.6.0. This is already fixed in the newer versions of NodeJS.