Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Custom login wallpapers #11025

Merged
merged 17 commits into from
Jun 20, 2018
Merged

Conversation

vynmera
Copy link
Contributor

@vynmera vynmera commented Jun 6, 2018

This PR allows people to customize their Rocket.Chats a bit more with a custom login wallpaper.

Right now it looks like this...
2018-06-06_21-16-36

But by tweaking this new option in Assets...
2018-06-06_21-18-14

...it can look like this!
2018-06-06_21-18-35

@rauhmaru
Copy link
Contributor

rauhmaru commented Jun 6, 2018

AWESOME!!!

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11025 June 11, 2018 18:30 Inactive
@ggazzo ggazzo self-requested a review June 11, 2018 20:00
@ggazzo
Copy link
Member

ggazzo commented Jun 11, 2018

@vynmera great feature! but I think you forgot some screens

image

@@ -1,5 +1,5 @@
<template name="loginLayout">
<section class="rc-old full-page color-tertiary-font-color">
<section class="rc-old full-page color-tertiary-font-color" style="background-image: url('{{ backgroundUrl }}')">
Copy link
Member

@ggazzo ggazzo Jun 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think about use one with?

<section class="rc-old full-page color-tertiary-font-color" {{with backgroundUrl}} style="background-image: url('{{ . }}')" {{/with}}>

backgroundUrl() {
const asset = RocketChat.settings.get('Assets_background');
const prefix = __meteor_runtime_config__.ROOT_URL_PATH_PREFIX || '';
if (asset != null) {
Copy link
Member

@ggazzo ggazzo Jun 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could 'improve' this if like

if (asset && prefix && (url || defaultUrl))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefix might not be set on all servers, so I'll leave that out

Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, fix this issues, if you think I'm wrong pls let me know :)

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11025 June 11, 2018 20:34 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11025 June 11, 2018 21:48 Inactive
@vynmera
Copy link
Contributor Author

vynmera commented Jun 11, 2018

This should fix the requested changes as much as possible:

@engelgabriel Register Username is now styled.
@ggazzo I had to change the syntax a bit and remove the prefix from your suggested if. Please rereview and tell me what you think :-)

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11025 June 11, 2018 21:58 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11025 June 11, 2018 21:59 Inactive
@RocketChat RocketChat deleted a comment Jun 11, 2018
@RocketChat RocketChat deleted a comment Jun 11, 2018
@RocketChat RocketChat deleted a comment Jun 11, 2018
@RocketChat RocketChat deleted a comment Jun 11, 2018
@RocketChat RocketChat deleted a comment Jun 11, 2018
@RocketChat RocketChat deleted a comment Jun 11, 2018
@RocketChat RocketChat deleted a comment Jun 11, 2018
@RocketChat RocketChat deleted a comment Jun 11, 2018
@vynmera
Copy link
Contributor Author

vynmera commented Jun 11, 2018

@kaiiiiiiiii Spacebars really doesn't like it when you do that, apparently. Doing it like this does seem to remove the style tag from DOM when unused though (unless Firefox is lying to me)

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11025 June 11, 2018 23:13 Inactive
@RocketChat RocketChat deleted a comment Jun 19, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11025 June 19, 2018 18:25 Inactive
@RocketChat RocketChat deleted a comment Jun 19, 2018
@RocketChat RocketChat deleted a comment from vynmera Jun 19, 2018
@RocketChat RocketChat deleted a comment from kaiiiiiiiii Jun 19, 2018
@RocketChat RocketChat deleted a comment Jun 19, 2018
@ggazzo ggazzo added this to Review/QA in June/2018 via automation Jun 20, 2018
@ggazzo ggazzo added this to the 0.66.0 milestone Jun 20, 2018
@ggazzo ggazzo added the ui/ux label Jun 20, 2018
@ggazzo ggazzo requested a deployment to rocket-chat-pr-11025 June 20, 2018 18:59 Abandoned
@ggazzo ggazzo requested a deployment to rocket-chat-pr-11025 June 20, 2018 18:59 Abandoned
@RocketChat RocketChat deleted a comment Jun 20, 2018
@RocketChat RocketChat deleted a comment from vynmera Jun 20, 2018
@RocketChat RocketChat deleted a comment from vynmera Jun 20, 2018
@ggazzo ggazzo requested a deployment to rocket-chat-pr-11025 June 20, 2018 19:11 Abandoned
@ggazzo ggazzo requested a deployment to rocket-chat-pr-11025 June 20, 2018 19:12 Abandoned
@ggazzo ggazzo merged commit d0ad44e into RocketChat:develop Jun 20, 2018
June/2018 automation moved this from Review/QA to Closed Jun 20, 2018
@rodrigok rodrigok mentioned this pull request Jun 28, 2018
@vynmera vynmera deleted the cool-background branch July 3, 2018 18:46
@localguru
Copy link
Contributor

@vynmera could you share the background image. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
June/2018
  
Closed
Development

Successfully merging this pull request may close these issues.

None yet

6 participants