-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Custom login wallpapers #11025
Conversation
AWESOME!!! |
@vynmera great feature! but I think you forgot some screens |
@@ -1,5 +1,5 @@ | |||
<template name="loginLayout"> | |||
<section class="rc-old full-page color-tertiary-font-color"> | |||
<section class="rc-old full-page color-tertiary-font-color" style="background-image: url('{{ backgroundUrl }}')"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think about use one with
?
<section class="rc-old full-page color-tertiary-font-color" {{with backgroundUrl}} style="background-image: url('{{ . }}')" {{/with}}>
backgroundUrl() { | ||
const asset = RocketChat.settings.get('Assets_background'); | ||
const prefix = __meteor_runtime_config__.ROOT_URL_PATH_PREFIX || ''; | ||
if (asset != null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could 'improve' this if
like
if (asset && prefix && (url || defaultUrl))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefix might not be set on all servers, so I'll leave that out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey, fix this issues, if you think I'm wrong pls let me know :)
This should fix the requested changes as much as possible: @engelgabriel Register Username is now styled. |
@kaiiiiiiiii Spacebars really doesn't like it when you do that, apparently. Doing it like this does seem to remove the style tag from DOM when unused though (unless Firefox is lying to me) |
@vynmera could you share the background image. :) |
This PR allows people to customize their Rocket.Chats a bit more with a custom login wallpaper.
Right now it looks like this...
But by tweaking this new option in Assets...
...it can look like this!