[FIX] open conversation from room info #11050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggazzo
changed the title
| @@ -55,7 +55,8 @@ export const getActions = function({ user, directActions, hideAdminControls }) { | |||
| }; | |||
| const canDirectMessage = (username) => { | |||
| const user = Meteor.user(); | |||
| return RocketChat.authz.hasAllPermission('create-d') && user && user.username !== username; | |||
| const rid = Session.get('openedRoom'); | |||
| return username && (!directActions && rid && RocketChat.models.Subscriptions.findOne({ rid }).name !== username) || (directActions && RocketChat.authz.hasAllPermission('create-d') && user && user.username !== username); | |||
There was a problem hiding this comment.
what about describing what each conditions does assigning a new variable?
const whatThisDoes = (!directActions && rid && RocketChat.models.Subscriptions.findOne({ rid }).name !== username);
const whatThisDoesAsWell = (directActions && RocketChat.authz.hasAllPermission('create-d') && user && user.username !== username);
return username && whatThisDoes || whatThisDoesAsWell;this will make the code easy to read and understand
gdelavald
previously approved these changes
Jun 12, 2018
gdelavald
approved these changes
Jun 13, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11007