[FIX] set-toolbar-items postMessage #11109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tassoevan
reviewed
Jun 14, 2018
| id: key, | ||
| ...toolbar.buttons[key] | ||
| }; | ||
| }); |
There was a problem hiding this comment.
Maybe compact mapper function as
id => ({ id, ...toolbar.buttons[id] })
| fireGlobalEvent('click-toolbar-button', { id: this.id }); | ||
| $('button', e.currentTarget).blur(); |
There was a problem hiding this comment.
e.currentTarget.querySelector('body').blur() should match the required browser supported.
| function(err) { | ||
| if (err) { | ||
| return handleError(err); | ||
| } |
There was a problem hiding this comment.
Could you avoid some extra lines using an arrow function?
tassoevan
requested changes
Jun 14, 2018
There was a problem hiding this comment.
Exception in template helper: TypeError: Cannot read property 'buttons' of undefined
at Object.postButtons (http://localhost:3000/packages/rocketchat_ui-flextab.js?hash=3e0ec2c95f4ca5993a961c6c2f5eee027e4cabc2:3719:39)
at http://localhost:3000/packages/blaze.js?hash=a1ff2d6d5ecd59ee11e2ba260b8650a9d1140f59:3051:16
at http://localhost:3000/packages/blaze.js?hash=a1ff2d6d5ecd59ee11e2ba260b8650a9d1140f59:1715:16
at http://localhost:3000/packages/blaze.js?hash=a1ff2d6d5ecd59ee11e2ba260b8650a9d1140f59:3103:66
at Function.Template._withTemplateInstanceFunc (http://localhost:3000/packages/blaze.js?hash=a1ff2d6d5ecd59ee11e2ba260b8650a9d1140f59:3744:12)
at http://localhost:3000/packages/blaze.js?hash=a1ff2d6d5ecd59ee11e2ba260b8650a9d1140f59:3102:27
at Object.Spacebars.call (http://localhost:3000/packages/spacebars.js?hash=547cf8e466d1d52603d19bd5f48fb5df184fd237:172:18)
at Template.RoomsActionTab.HTML.DIV.class (http://localhost:3000/packages/rocketchat_ui-flextab.js?hash=3e0ec2c95f4ca5993a961c6c2f5eee027e4cabc2:127:22)
at Blaze.View.<anonymous> (http://localhost:3000/packages/spacebars.js?hash=547cf8e466d1d52603d19bd5f48fb5df184fd237:264:18)
at http://localhost:3000/packages/blaze.js?hash=a1ff2d6d5ecd59ee11e2ba260b8650a9d1140f59:1934:20
…-set-toolbar-button
tassoevan
approved these changes
Jun 14, 2018
ggazzo
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some refactors and this code was deleted...