Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Default selected language #11150

Merged
merged 11 commits into from
Jun 19, 2018
Merged

[FIX] Default selected language #11150

merged 11 commits into from
Jun 19, 2018

Conversation

tassoevan
Copy link
Contributor

When no language is defined in settings, correctly shows Default as the selected option.

@tassoevan tassoevan requested a review from ggazzo June 14, 2018 15:05
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11150 June 14, 2018 15:06 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11150 June 14, 2018 17:43 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11150 June 14, 2018 19:04 Inactive
@engelgabriel engelgabriel added this to Review/QA in June/2018 via automation Jun 15, 2018
@engelgabriel engelgabriel added this to the 0.66.0 milestone Jun 15, 2018
@ggazzo ggazzo moved this from Review/QA to Ready to merge in June/2018 Jun 15, 2018
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the user profile page too :)

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11150 June 18, 2018 19:08 Inactive
@tassoevan tassoevan changed the title [FIX] Default selected language in administration page [FIX] Default selected language Jun 18, 2018
@tassoevan tassoevan changed the title [FIX] Default selected language [WIP[FIX] Default selected language Jun 18, 2018
@tassoevan tassoevan changed the title [WIP[FIX] Default selected language [WIP] [FIX] Default selected language Jun 18, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11150 June 18, 2018 21:56 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11150 June 19, 2018 04:48 Inactive
@tassoevan tassoevan changed the title [WIP] [FIX] Default selected language [FIX] Default selected language Jun 19, 2018
@ggazzo ggazzo merged commit 6395b89 into develop Jun 19, 2018
June/2018 automation moved this from Ready to merge to Closed Jun 19, 2018
@ggazzo ggazzo deleted the fix-admin-default-language branch June 19, 2018 21:16
@rodrigok rodrigok mentioned this pull request Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
June/2018
  
Closed
Development

Successfully merging this pull request may close these issues.

None yet

3 participants