Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Livechat not sending desktop notifications #11266

Merged
merged 3 commits into from
Jul 6, 2018

Conversation

renatobecker-zz
Copy link

@renatobecker-zz renatobecker-zz commented Jun 26, 2018

Closes #11031.

This PR fixes Livechat desktop notifications that weren't showing up on new messages.

@renatobecker-zz renatobecker-zz added this to the 0.66.0 milestone Jun 26, 2018
@renatobecker-zz renatobecker-zz added this to Desireable in Livechat via automation Jun 26, 2018
@renatobecker-zz renatobecker-zz added this to Review/QA in June/2018 via automation Jun 26, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11266 June 26, 2018 21:12 Inactive
@renatobecker-zz renatobecker-zz moved this from Desireable to Review/QA in Livechat Jun 26, 2018
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When enabling Use Real Name I'm getting this notifications:
image

disclaimer: ao is the livechat visitor's name (the sharp added to it is also weird).. and aue is the message the visitor sent

@sampaiodiego sampaiodiego temporarily deployed to rocket-chat-pr-11266 July 5, 2018 19:47 Inactive
sampaiodiego
sampaiodiego previously approved these changes Jul 5, 2018
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed to show a [livechat] in front of the notification title (since we don't a single character to show there - like @ or #):

image

if visitor has no name, it shows his guest counter:
image

@rodrigok rodrigok modified the milestones: 0.66.0, 0.66.2 Jul 5, 2018
rodrigok
rodrigok previously approved these changes Jul 5, 2018
Copy link
Member

@rodrigok rodrigok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code approved

@sampaiodiego sampaiodiego changed the title [FIX] Livechat desktop notifications [FIX] Livechat not sending desktop notifications Jul 6, 2018
@sampaiodiego sampaiodiego dismissed stale reviews from rodrigok and themself via aec6d40 July 6, 2018 02:38
@sampaiodiego sampaiodiego force-pushed the livechat-desktop-notifications branch from 5a691ca to aec6d40 Compare July 6, 2018 02:38
@sampaiodiego sampaiodiego temporarily deployed to rocket-chat-pr-11266 July 6, 2018 02:38 Inactive
@sampaiodiego sampaiodiego merged commit 22d1cae into develop Jul 6, 2018
June/2018 automation moved this from Review/QA to Closed Jul 6, 2018
@sampaiodiego sampaiodiego deleted the livechat-desktop-notifications branch July 6, 2018 03:23
@sampaiodiego sampaiodiego mentioned this pull request Jul 6, 2018
@renatobecker-zz
Copy link
Author

@sampaiodiego, just give you a feedback on the changes made in this fix..
I really like the approach using roomTypes in cases like this because through this pattern we can keep the code in the correct place, avoiding injecting specific subsystem code into the core notifications system, for example.
So, if we can keep this pattern in the next implementations that are coming, this can make implementation more consistent.

Thanks.

@renatobecker-zz renatobecker-zz moved this from Review/QA to Closed in Livechat Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Livechat
  
Closed
June/2018
  
Closed
Development

Successfully merging this pull request may close these issues.

[BUG] Livechat does not show notifications on Windows 10.
5 participants