[FIX] Armhf snap build #11268
[FIX] Armhf snap build #11268
Conversation
|
Launchpad is still giving some issues... Its arm64 hardware trying to emulate armhf... Most of the time does a good job. But sharp its not working great. |
|
Builds via launchpad just aren't going to be a possibility right now. But as is, will work if built on a raspberry pi. So for now... will manually do periodically until we can get maybe some help from launchpad guys to figure out why its not faking armhf good enough :) |
| @@ -2,11 +2,18 @@ | |||
|
|
|||
| curl -SLf "https://releases.rocket.chat/#{RC_VERSION}/download/" -o rocket.chat.tgz | |||
|
|
|||
| tar xvf rocket.chat.tgz --strip 1 | |||
| tar xvf rocket.chat.tgz --strip 1 > /dev/null | |||
There was a problem hiding this comment.
I think removing v option should be enough.. no need to > /dev/null
There was a problem hiding this comment.
Doh! Duh. Habit to do tar xvf forget about the v 😁
.snapcraft/resources/preparenode
Outdated
| fi | ||
|
|
||
|
|
||
| wget https://nodejs.org/dist/$node_version/node-$node_version-linux-$node_arch.tar.xz; tar xvf node-$node_version-linux-$node_arch.tar.xz --strip 1 > /dev/null; |
There was a problem hiding this comment.
any reason to no split this into two lines?
same thing here, just removing v option from tar will make it silent, no need to > /dev/null
There was a problem hiding this comment.
No reason. Copied directly from the inline in the snapcraft.yaml . fixed :)
Closes #8555
Closes #10653
Remove the emoji one node module that depends on phantomjs.
It appears that in our CI when we do npm install it installs devDependencies. Which on its own is fine. But when we do meteor build, it compiles and copies over the dev dependencies also. So it installs the grunt-contrib-qunit package, which has hard depend on phantomjs.
We should look at adding NODE_ENV=production to our ci to prevent it from installing dev dependencies. Would likely reduce the size of our resulting bundle.
Also remove the sharp/vendor folder so that during the npm install it will download the pre-compiled binaries for arm. It seems like it downloads and fails if that folder is there.