-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Fixed svg for older chrome browsers bug #11414 #11416
Merged
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ec92ef6
Fixed svg for older chrome browsers bug #11414
tpDBL f8791d6
Merge branch 'develop' into fix-svg-chrome
tpDBL cfadcdd
Created own check for Chrome
tpDBL 8ada76a
Fixed broken lint comment
tpDBL c251e79
Merge branch 'develop' into fix-svg-chrome
tpDBL f52b54f
Fixed 'space-in-parens' mistake
tpDBL a1cbdff
Merge branch 'fix-svg-chrome' of https://github.com/tpDBL/Rocket.Chat…
tpDBL File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,5 +3,5 @@ | |
const firefoxBaseUrlFix = () => `${ window.location.origin }${ FlowRouter.current().path }`; | ||
|
||
Template.icon.helpers({ | ||
baseUrl: isFirefox && isFirefox[1] < 55 ? firefoxBaseUrlFix : undefined | ||
baseUrl: isFirefox && isFirefox[2] < 55 ? firefoxBaseUrlFix : undefined | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it the same version number for both browsers? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes |
||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For clarity, it's better to keep the original statement and add a new one assigning to
this.isChrome
.