Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Unlimited upload file size not working #11471

Merged
merged 3 commits into from
Jul 21, 2018

Conversation

Hudell
Copy link
Contributor

@Hudell Hudell commented Jul 16, 2018

This PR fixes a problem where instances configured to have unlimited uploads were failing to upload every file.

This might be the problem causing #10278, but further testing is needed.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11471 July 16, 2018 14:40 Inactive
sampaiodiego
sampaiodiego previously approved these changes Jul 17, 2018
@sampaiodiego
Copy link
Member

What about adding a description to setting explaining -1 means unlimited?

@sampaiodiego sampaiodiego added this to the 0.68.0 milestone Jul 17, 2018
@sampaiodiego sampaiodiego merged commit 5ea5d26 into develop Jul 21, 2018
@sampaiodiego sampaiodiego deleted the fix.max-upload-file-size branch July 21, 2018 01:30
@sampaiodiego sampaiodiego mentioned this pull request Jul 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants