Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Message attachments was not respecting sort and lost spacing #11740

Merged
merged 2 commits into from
Aug 13, 2018

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Aug 10, 2018

the pr #11342 introduced a small bug on the attachments, this pr fix this problem

before

image

after

short
image
normal
image

Closes #11669

@ggazzo ggazzo added the ui/ux label Aug 10, 2018
@ggazzo ggazzo added this to In progress in August/2018 via automation Aug 10, 2018
@ggazzo ggazzo added this to the 0.69.0 milestone Aug 10, 2018
August/2018 automation moved this from In progress to Ready to merge Aug 10, 2018
@rodrigok rodrigok changed the title [FIX] message attachments (padding, order and short) [FIX] Message attachments was not respecting sort and lost spacing Aug 13, 2018
@rodrigok rodrigok merged commit 37926d9 into develop Aug 13, 2018
August/2018 automation moved this from Ready to merge to Done Aug 13, 2018
@rodrigok rodrigok deleted the fix-attach branch August 13, 2018 13:31
@sampaiodiego sampaiodiego mentioned this pull request Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
August/2018
  
Done
Development

Successfully merging this pull request may close these issues.

Output of webhooks appear incorrectly in chat
4 participants