[FIX] Load whole file into memory before parsing JSON. #11755
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@jakob-lundberg can you fix the conflicts and the lint errors? |
|
@jakob-lundberg Any chance this can be fixed and merged soon. Last blocker for migrating from Hipchat to RocketChat. |
|
this was accomplished by #11597 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11355
Load whole file into memory before parsing JSON.
Currently the json files are loaded in chunks and the chunks are json decoded. But if a file does not fit in a chunk only part of the file will be decoded. And then the decoding will fail as it is not correct JSON.
With this change the entire file is first loaded into memory and then JSON decoded. This will result in valid JSON. It will however require that there is enough memory to load the entire file.