[FIX] Fix issue cannot filter channels by name #12952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ggazzo
previously approved these changes
Feb 5, 2019
|
hey @huydang284, you pr looks good, but I could not find where we are using that method, ( I was thinking about remove it) I just found old templates using this method, could you say me here you are using this methods? |
|
Hi @ggazzo, I used that method in my custom project. |
|
@huydang284 please check if there is another method that you could use instead, because, probably we gonna remove that method... |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
I fix the issue that cannot filter channels by name. I think it was a mistake.
Regards,
Huy Dang