Convert rocketchat-logger to main module structure and remove Logger from eslintrc

.eslintrc

@@ -13,10 +13,10 @@
 		"FileUpload"                  : false,
 		"handleError"                 : false,
 		"getAvatarUrlFromUsername"    : false,
-		"Logger"                      : false,
 		"modal"                       : false,
 		"Npm"                         : false,
 		"Package"                     : false,
+		"readMessage"                 : false,
 		"RocketChat"                  : true,
 		"RoomHistoryManager"          : false,
 		"RoomManager"                 : false,

packages/rocketchat-custom-oauth/package.js

@@ -12,6 +12,7 @@ Package.onUse(function(api) {
 	api.use('ecmascript');
 	api.use('accounts-oauth');
 	api.use('service-configuration');
+	api.use('rocketchat:logger');
 
 	api.use('templating', 'client');
 

packages/rocketchat-custom-oauth/server/custom_oauth_server.js

@@ -4,6 +4,7 @@ import { Match } from 'meteor/check';
 import { Accounts } from 'meteor/accounts-base';
 import { HTTP } from 'meteor/http';
 import { ServiceConfiguration } from 'meteor/service-configuration';
+import { Logger } from 'meteor/rocketchat:logger';
 import _ from 'underscore';
 
 const logger = new Logger('CustomOAuth');

packages/rocketchat-file-upload/server/config/GridFS.js

@@ -2,7 +2,7 @@
 import stream from 'stream';
 import zlib from 'zlib';
 import util from 'util';
-
+import { Logger } from 'meteor/rocketchat:logger';
 import { FileUploadClass } from '../lib/FileUpload';
 
 const logger = new Logger('FileUpload');

packages/rocketchat-file-upload/server/lib/proxy.js

@@ -2,6 +2,7 @@
 
 import { Meteor } from 'meteor/meteor';
 import { WebApp } from 'meteor/webapp';
+import { Logger } from 'meteor/rocketchat:logger';
 import http from 'http';
 import URL from 'url';
 

packages/rocketchat-lib/lib/templateVarHandler.js

@@ -1,4 +1,5 @@
 import { Meteor } from 'meteor/meteor';
+import { Logger } from 'meteor/rocketchat:logger';
 
 let logger;
 

packages/rocketchat-lib/server/functions/getFullUserData.js

@@ -1,5 +1,6 @@
 /* globals RocketChat */
 import s from 'underscore.string';
+import { Logger } from 'meteor/rocketchat:logger';
 
 const logger = new Logger('getFullUserData');
 

packages/rocketchat-lib/server/lib/configLogger.js

@@ -1,5 +1,5 @@
-/* globals LoggerManager */
 import { Meteor } from 'meteor/meteor';
+import { LoggerManager } from 'meteor/rocketchat:logger';
 
 RocketChat.settings.get('Log_Package', function(key, value) {
 	return LoggerManager.showPackage = value;

packages/rocketchat-lib/server/lib/debug.js

@@ -2,6 +2,7 @@
 import { Meteor } from 'meteor/meteor';
 import { WebApp } from 'meteor/webapp';
 import _ from 'underscore';
+import { Logger } from 'meteor/rocketchat:logger';
 
 const logger = new Logger('Meteor', {
 	methods: {

packages/rocketchat-lib/server/startup/oAuthServicesUpdate.js

@@ -1,6 +1,7 @@
 /* globals CustomOAuth */
 import { Meteor } from 'meteor/meteor';
 import { ServiceConfiguration } from 'meteor/service-configuration';
+import { Logger } from 'meteor/rocketchat:logger';
 import _ from 'underscore';
 
 const logger = new Logger('rocketchat:lib', {

packages/rocketchat-logger/client/ansispan.js

@@ -1,6 +1,4 @@
-/* globals ansispan:true */
-
-ansispan = function(str) {
+export const ansispan = function(str) {
 	str = str.replace(/>/g, '>');
 	str = str.replace(/</g, '&lt;');
 

packages/rocketchat-logger/client/index.js

@@ -0,0 +1,4 @@
+import './logger';
+import './viewLogs';
+import './views/viewLogs.html';
+import './views/viewLogs';

packages/rocketchat-logger/client/viewLogs.js

@@ -3,7 +3,7 @@ import { Mongo } from 'meteor/mongo';
 import { FlowRouter } from 'meteor/kadira:flow-router';
 import { BlazeLayout } from 'meteor/kadira:blaze-layout';
 
-this.stdout = new Mongo.Collection('stdout');
+export const stdout = new Mongo.Collection('stdout');
 
 Meteor.startup(function() {
 	RocketChat.AdminBox.addOption({

packages/rocketchat-logger/client/views/viewLogs.js

@@ -1,9 +1,9 @@
 import { Meteor } from 'meteor/meteor';
 import { Template } from 'meteor/templating';
+import { ansispan } from '../ansispan';
+import { stdout } from '../viewLogs';
 import _ from 'underscore';
 import moment from 'moment';
-// TODO: remove this globals
-/* globals ansispan stdout readMessage*/
 
 Template.viewLogs.onCreated(function() {
 	this.subscribe('stdout');

packages/rocketchat-logger/package.js

@@ -5,24 +5,17 @@ Package.describe({
 });
 
 Package.onUse(function(api) {
-	api.use('mongo');
-	api.use('ecmascript');
-	api.use('random');
-	api.use('logging');
-	api.use('nooitaf:colors');
-	api.use('raix:eventemitter');
-	api.use('templating', 'client');
-	api.use('kadira:flow-router', 'client');
-	api.use('kadira:blaze-layout', 'client');
-	api.addFiles('client/ansispan.js', 'client');
-	api.addFiles('client/logger.js', 'client');
-	api.addFiles('client/viewLogs.js', 'client');
-	api.addFiles('client/views/viewLogs.html', 'client');
-	api.addFiles('client/views/viewLogs.js', 'client');
-
-	api.addFiles('server/server.js', 'server');
-
-	api.export('Logger');
-	api.export('SystemLogger');
-	api.export('LoggerManager');
+	api.use([
+		'ecmascript',
+		'mongo',
+		'random',
+		'logging',
+		'nooitaf:colors',
+		'raix:eventemitter',
+		'templating',
+		'kadira:flow-router',
+		'kadira:blaze-layout',
+	]);
+	api.mainModule('client/index.js', 'client');
+	api.mainModule('server/index.js', 'server');
 });

packages/rocketchat-logger/server/index.js

@@ -0,0 +1,7 @@
+import { LoggerManager, Logger, SystemLogger } from './server';
+
+export {
+	LoggerManager,
+	Logger,
+	SystemLogger,
+};

packages/rocketchat-logger/server/server.js

@@ -1,12 +1,14 @@
-/* globals EventEmitter LoggerManager SystemLogger Log*/
 import { Meteor } from 'meteor/meteor';
 import { Random } from 'meteor/random';
 import { EJSON } from 'meteor/ejson';
+import { Log } from 'meteor/logging';
+import { EventEmitter } from 'events';
 import _ from 'underscore';
 import s from 'underscore.string';
 
-// TODO: change this global to import
-LoggerManager = new class extends EventEmitter { // eslint-disable-line no-undef
+let Logger;
+
+const LoggerManager = new class extends EventEmitter {
 	constructor() {
 		super();
 		this.enabled = false;
@@ -46,7 +48,6 @@ LoggerManager = new class extends EventEmitter { // eslint-disable-line no-undef
 	}
 };
 
-
 const defaultTypes = {
 	debug: {
 		name: 'debug',
@@ -297,8 +298,8 @@ class _Logger {
 		}
 	}
 }
-// TODO: change this global to import
-Logger = global.Logger = _Logger;
+
+Logger = _Logger;
 const processString = function(string, date) {
 	let obj;
 	try {
@@ -316,8 +317,8 @@ const processString = function(string, date) {
 		return string;
 	}
 };
-// TODO: change this global to import
-SystemLogger = new Logger('System', { // eslint-disable-line no-undef
+
+const SystemLogger = new Logger('System', {
 	methods: {
 		startup: {
 			type: 'success',

server/lib/cordova.js

@@ -1,7 +1,8 @@
-/* global Push, SystemLogger */
+/* global Push */
 import { Meteor } from 'meteor/meteor';
 import { HTTP } from 'meteor/http';
 import { TAPi18n } from 'meteor/tap:i18n';
+import { SystemLogger } from 'meteor/rocketchat:logger';
 
 Meteor.methods({
 	// log() {

server/startup/cron.js

@@ -1,7 +1,7 @@
 /* global SyncedCron */
 import { Meteor } from 'meteor/meteor';
 import { HTTP } from 'meteor/http';
-
+import { Logger } from 'meteor/rocketchat:logger';
 const logger = new Logger('SyncedCron');
 
 SyncedCron.config({

server/startup/migrations/v099.js

@@ -1,9 +1,8 @@
-/* globals SystemLogger */
-
 import { Meteor } from 'meteor/meteor';
 import { Match } from 'meteor/check';
 import { Mongo } from 'meteor/mongo';
 import { RocketChatFile } from 'meteor/rocketchat:file';
+import { SystemLogger } from 'meteor/rocketchat:logger';
 import fs from 'fs';
 import path from 'path';
 

server/startup/serverRunning.js

@@ -1,6 +1,7 @@
-/* globals MongoInternals, SystemLogger */
+/* globals MongoInternals */
 
 import { Meteor } from 'meteor/meteor';
+import { SystemLogger } from 'meteor/rocketchat:logger';
 import fs from 'fs';
 import path from 'path';
 import semver from 'semver';

server/stream/streamBroadcast.js

@@ -1,9 +1,10 @@
-/* global InstanceStatus, DDP, LoggerManager */
+/* global InstanceStatus, DDP */
 
 import { Meteor } from 'meteor/meteor';
 import { check } from 'meteor/check';
 import _ from 'underscore';
 import { DDPCommon } from 'meteor/ddp-common';
+import { Logger, LoggerManager } from 'meteor/rocketchat:logger';
 
 process.env.PORT = String(process.env.PORT).trim();
 process.env.INSTANCE_IP = String(process.env.INSTANCE_IP).trim();