[IMPROVE] new icons #13289
Merged
[IMPROVE] new icons #13289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ggazzo
commented
Jan 30, 2019
•
ggazzo
commented
- updated some icons
- html generator to check icons
- sprite generator
* develop: [NEW] Limit all DDP/Websocket requests (configurable via admin panel) (#13311) [FIX] Mobile view and re-enable E2E tests (#13322) [NEW] REST endpoint to forward livechat rooms (#13308) [FIX] Hipchat Enterprise Importer not generating subscriptions (#13293) [FIX] Message updating by Apps (#13294) [FIX] REST endpoint for creating custom emojis (#13306) [FIX] Preview of image uploads were not working when apps framework is enable (#13303)
tassoevan
requested changes
Feb 4, 2019
| @@ -155,13 +155,6 @@ | |||
| font-size: 1rem; | |||
| } | |||
|
|
|||
| &__room-type { | |||
There was a problem hiding this comment.
Please remove sidebar-item__room-type from templates too.
tassoevan
previously requested changes
Feb 4, 2019
| // play animation | ||
| $(e.currentTarget).find('.rc-icon').addClass('play'); | ||
| $(e.currentTarget).parent().addClass('loading'); |
There was a problem hiding this comment.
Could we avoid jQuery here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.