[NEW] users.setActiveStatus endpoint in rest api #13443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thayannevls Can you please add some tests and docs for this endpoint? |
d-gubert
requested changes
Feb 12, 2019
| .end(done); | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
@thayannevls can you add a test case for the user trying update your own status?
d-gubert
previously approved these changes
Feb 14, 2019
d-gubert
dismissed
their stale review
The branch has conflicts, should approve when they're resolved
|
@thayannevls the tests are broken. Can you please take a look? :) |
|
@MarcosSpessatto Fixed it. Can you check? |
|
Thank you @thayannevls 👍 |
MarcosSpessatto
approved these changes
Feb 15, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13425
Add new endpoint that allows to set the user Active Status using the REST API