Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAK] Remove internal hubot package #13522

Merged
merged 1 commit into from
Feb 19, 2019
Merged

[BREAK] Remove internal hubot package #13522

merged 1 commit into from
Feb 19, 2019

Conversation

MarcosSpessatto
Copy link
Contributor

No description provided.

@MarcosSpessatto MarcosSpessatto added this to the 0.75.0 milestone Feb 19, 2019
@engelgabriel engelgabriel requested a deployment to rocket-chat-pr-13522 February 19, 2019 19:31 Abandoned
@geekgonecrazy geekgonecrazy changed the title Remove internal hubot package [BREAK] Remove internal hubot package Feb 19, 2019
@geekgonecrazy
Copy link
Member

geekgonecrazy commented Feb 19, 2019 •
edited
Loading

Updated title. We for sure must label this one as a breaking change

Personally very happy about this change. External is definitely where it belongs :)

@rodrigok rodrigok merged commit 5adc11f into develop Feb 19, 2019
@rodrigok rodrigok deleted the remove-internal-hubot branch February 19, 2019 19:56
@thaiphv
Copy link
Contributor

thaiphv commented Mar 11, 2019

How is it going to affect existing installations of Rocket.Chat when we upgrade them to this release?

@geekgonecrazy
Copy link
Member

You would have to move to external hubot. The scripts should work identically

@thaiphv
Copy link
Contributor

thaiphv commented Mar 11, 2019

Thanks for the clarification @geekgonecrazy

@tholu
Copy link
Contributor

tholu commented Mar 22, 2019

@geekgonecrazy So using https://github.com/RocketChat/hubot-rocketchat in a docker deployment is just fine, right?

@geekgonecrazy
Copy link
Member

@geekgonecrazy So using https://github.com/RocketChat/hubot-rocketchat in a docker deployment is just fine, right?

correct!

@lennartgrunau lennartgrunau mentioned this pull request Apr 1, 2019
Closed
@whande1992
Copy link

whande1992 commented Apr 5, 2019 •
edited
Loading

Com o Hubut interno, era possível utilizar o recurso em todos os canais\salas de forma publica ou privada, agora, não funciona nas salas comuns de usuário x usuário, somente em usuário x but. Qual a forma de solucionar isso ?

@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Merged
@crazy-max crazy-max mentioned this pull request May 2, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigok rodrigok rodrigok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@MarcosSpessatto @geekgonecrazy @thaiphv @tholu @whande1992 @rodrigok @engelgabriel