Move mongo config away from cors package #13531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcosSpessatto
previously approved these changes
Feb 20, 2019
sampaiodiego
requested changes
Feb 20, 2019
| import tls from 'tls'; | ||
| // FIX For TLS error see more here https://github.com/RocketChat/Rocket.Chat/issues/9316 | ||
| // TODO: Remove after NodeJS fix it, more information https://github.com/nodejs/node/issues/16196 https://github.com/nodejs/node/pull/16853 | ||
| tls.DEFAULT_ECDH_CURVE = 'auto'; |
There was a problem hiding this comment.
do we still need this? seems node have fixed it already.
this is not related to mongo btw, so I don't it should be in this package =) but my vote is to remove.
sampaiodiego
approved these changes
Feb 22, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.