Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX]Found a grammatical mistake in this page. Corrected. #13558

Closed
wants to merge 2 commits into from
Closed

[FIX]Found a grammatical mistake in this page. Corrected. #13558

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2876a7f
Found a grammatical mistake in this page. Corrected.
gsunit Feb 23, 2019
64c81b3
grammatical fix in en18n.json to complement previous commit
gsunit Feb 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/routes/pageNotFound.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template name="pageNotFound">
<h1>{{_ "Error_404"}}</h1>
<h3>{{_ "Oops_page_not_found"}}</h3>
<p>{{_ "Sorry_page_you_requested_does_not_exists_or_was_deleted"}}</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for address this misspelling, however this is just a translation key. All files under packages/rocketchat-i18n/i18n must be updated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at packages/rocketchat-i18n/i18n/en.i18n.json. The key value pair corresponding to error is "Error_404": "Error:404", which seems correct. Could you please elaborate what needs to be changed in the i18n folder? I'll make the necessary changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has nothing to do with Error_404, but with Sorry_page_you_requested_does_not_exists_or_was_deleted itself. Just look at the file for English translation. By updating the key to Sorry_page_you_requested_does_not_exist_or_was_deleted, you need to update it in the translation files too, because the text is retrieved from there.

Copy link
Contributor Author

@gsunit gsunit Feb 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the required changes. Please let me know if anything else needs to be done.

<p>{{_ "Sorry_page_you_requested_does_not_exist_or_was_deleted"}}</p>
</template>