Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Discussions - Invite users and DM #13646

Merged
merged 4 commits into from
Mar 8, 2019
Merged

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Mar 8, 2019

No description provided.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13646 March 8, 2019 15:25 Inactive
@ggazzo ggazzo requested a review from sampaiodiego March 8, 2019 15:26
@ggazzo ggazzo changed the title [FIX] Threads - Invite users and DM Regression Threads - Invite users and DM Mar 8, 2019
@ggazzo ggazzo changed the title Regression Threads - Invite users and DM Regression: Threads - Invite users and DM Mar 8, 2019
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-13646 March 8, 2019 16:55 Inactive
@@ -44,7 +44,7 @@ Template.CreateThread.helpers({
if (message) {
users.unshift(message.u);
}
return users;
return users.filter(({ username }) => Meteor.user().username !== username);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls change to have the username in an external variable

…eThread.js

Co-Authored-By: ggazzo <guilhermegazzo@gmail.com>
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-13646 March 8, 2019 18:20 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-13646 March 8, 2019 18:23 Inactive
@ggazzo ggazzo added this to the 1.0.0 milestone Mar 8, 2019
@sampaiodiego sampaiodiego merged commit 40a2c9f into develop Mar 8, 2019
@sampaiodiego sampaiodiego deleted the fix/threads branch March 8, 2019 21:15
@engelgabriel engelgabriel changed the title Regression: Threads - Invite users and DM Regression: Discussions - Invite users and DM Mar 21, 2019
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants