-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression: Discussions - Invite users and DM #13646
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggazzo
changed the title
[FIX] Threads - Invite users and DM
Regression Threads - Invite users and DM
Mar 8, 2019
ggazzo
changed the title
Regression Threads - Invite users and DM
Regression: Threads - Invite users and DM
Mar 8, 2019
11 tasks
sampaiodiego
requested changes
Mar 8, 2019
packages/assistify-threading/client/views/creationDialog/CreateThread.js
Outdated
Show resolved
Hide resolved
@@ -44,7 +44,7 @@ Template.CreateThread.helpers({ | |||
if (message) { | |||
users.unshift(message.u); | |||
} | |||
return users; | |||
return users.filter(({ username }) => Meteor.user().username !== username); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls change to have the username in an external variable
…eThread.js Co-Authored-By: ggazzo <guilhermegazzo@gmail.com>
sampaiodiego
approved these changes
Mar 8, 2019
engelgabriel
changed the title
Regression: Threads - Invite users and DM
Regression: Discussions - Invite users and DM
Mar 21, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.