Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Add Voxtelesys to list of SMS providers #13697

Merged
merged 8 commits into from
Apr 15, 2019
Merged

[NEW] Add Voxtelesys to list of SMS providers #13697

merged 8 commits into from
Apr 15, 2019

Conversation

john08burke
Copy link
Contributor

Hello!

I made some mods to integrate Voxtelesys into the list of livechat SMS providers. The API uses Bearer authentication and I implemented the /api/v1/sms method for outbound messaging.

Not sure who to @ to review?

vts_sms

@CLAassistant
Copy link

CLAassistant commented Mar 13, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sampaiodiego sampaiodiego self-assigned this Apr 6, 2019
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from their docs looks like they use an different authentication: then you're proposing: authorization: Token token=176a78b0-8e81-4e56-9e3f-da67d17915bb

also how do you create this token? can you please provide an explanation for other on how to set this integration up? thanks

@john08burke
Copy link
Contributor Author

The docs have been updated. The Token token=<uuid> was the original method of authentication, which mirrored an OAuth2.0-style of authentication. Traditional Bearer authentication was added awhile ago for simplicity. The proposed code opted for the simplistic Bearer approach.

Tokens are assigned upon account creation, here. Right now this is a manual assignment from Voxtelesys after the user has created an account, but will be automated soon.

@sampaiodiego
Copy link
Member

alright, thanks @john08burke .. lgtm =)

@sampaiodiego sampaiodiego merged commit 0227f8b into RocketChat:develop Apr 15, 2019
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants