Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVE] Filter agents with autocomplete input instead of select element #13730

Merged
merged 3 commits into from
Mar 22, 2019
Merged

[IMPROVE] Filter agents with autocomplete input instead of select element #13730

merged 3 commits into from
Mar 22, 2019

Conversation

renatobecker-zz
Copy link

@renatobecker-zz renatobecker-zz commented Mar 15, 2019 •
edited
Loading

Closes #13728

Everything is working fine with the new components: autocomplete and rc-select:

Screen Shot 2019-03-21 at 17 39 35

But there is a fix needed related to alignment of the components:

Screen Shot 2019-03-21 at 17 39 43

@ggazzo, can you please take a look at this?
Thanks.

@renatobecker-zz renatobecker-zz added this to In progress in Omnichannel Roadmap via automation Mar 15, 2019
@renatobecker-zz renatobecker-zz added this to the 1.0.0 milestone Mar 15, 2019
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13730 March 15, 2019 14:41 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13730 March 15, 2019 16:51 Inactive
@renatobecker
Merge branch 'develop' into replace-agents-select-by-auto-complete-se…
de18de1 
…arch

# Conflicts:
#	app/livechat/client/views/app/livechatCurrentChats.js
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13730 March 15, 2019 21:49 Inactive
@renatobecker-zz renatobecker-zz moved this from In progress to Needs review in Omnichannel Roadmap Mar 18, 2019
ggazzo
ggazzo requested changes Mar 19, 2019
View reviewed changes
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think about use the new templates and update the select to rc-select ?

@renatobecker-zz
Copy link
Author

renatobecker-zz commented Mar 21, 2019 •
edited
Loading

what do you think about use the new templates and update the select to rc-select ?

Cool! I'll take a look at this now.
Thanks.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13730 March 21, 2019 20:41 Inactive
@ggazzo ggazzo force-pushed the replace-agents-select-by-auto-complete-search branch from 9d77c37 to de18de1 Compare March 22, 2019 17:35
@ggazzo ggazzo requested a deployment to rocket-chat-pr-13730 March 22, 2019 17:36 Abandoned
Omnichannel Roadmap automation moved this from Needs review to Reviewer approved Mar 22, 2019
@ggazzo ggazzo merged commit ceb6539 into develop Mar 22, 2019
Omnichannel Roadmap automation moved this from Reviewer approved to Done Mar 22, 2019
@ggazzo ggazzo deleted the replace-agents-select-by-auto-complete-search branch March 22, 2019 17:37
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

@engelgabriel engelgabriel Awaiting requested review from engelgabriel

@sampaiodiego sampaiodiego Awaiting requested review from sampaiodiego

Assignees

@ggazzo ggazzo

Labels
squad: omnichannel subj: livechat ui/ux
Projects
Omnichannel Roadmap
  
Done
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Turn agents drop down into regular users autocomplete and remove publication
5 participants
@renatobecker-zz @ggazzo @engelgabriel @tassoevan @renatobecker