-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMPROVE] UI of Permissions page #13732
Conversation
hey man before commit try run |
The ID only looks redundant in English, but they are very helpful in other languages. |
@engelgabriel For a user in another language, he would be able to see Permission in his native language as well as the Permission in ID (english). I personally, think that it would be redundant. However if you suggest, I can push a commit to display the ID in a smaller font and a greyed out color. That would be more appealing to the user. The rest of my commits focus on displaying of all roles and horizontal scrolling on small devices. |
Ok, let's try the following:
The result should be something similar to the "Browser compatibility" table at https://developer.mozilla.org/en-US/docs/Web/CSS/text-orientation#Browser_compatibility |
The Permission ID in a smaller font and a greyed out color in monospace font underneath could look good too. |
Working on it. |
|
Thank you so much @fliptrail it is almost perfect. I have some suggestions to make it a bit better, but they are not required for us to merge this PR.
|
Edit icon is I guess necessary to show that roles can be edited. |
I will try to put custom checkboxes. |
I don't have a problem with the native checkboxes, keep them. Just fix the vertical alignment. |
Thank you so much @fliptrail |
… into emoji-upgrades * 'emoji-upgrades' of https://github.com/wreiske/Rocket.Chat: Settings: disable reset button (RocketChat#14026) Settings: hiding reset button for readonly fields (RocketChat#14025) [NEW] Add support to updatedSince parameter in emoji-custom.list and deprecated old endpoint (RocketChat#13510) [IMPROVE] Add permission to change other user profile avatar (RocketChat#13884) [IMPROVE] UI of Permissions page (RocketChat#13732) [NEW] Chatpal: Enable custom search parameters (RocketChat#13828) (RocketChat#13829) [FIX] Closing sidebar when room menu is clicked. (RocketChat#13842) [FIX] Check settings for name requirement before validating (RocketChat#14021) Fix debug logging not being enabled by the setting (RocketChat#13979) [FIX] Links and upload paths when running in a subdir (RocketChat#13982)
Closes #13700
This improves the UI of Permissions page. Now, all the roles are properly visible with horizontal scroll support for small screen devices. The text alignment and size of check boxes have been changed as well as size of edit icon. Also, now, the names of permissions are visible and the ID of permissions is hidden, (which earlier was redundant).
Initial State
![Screenshot from 2019-03-14 04-21-23](https://user-images.githubusercontent.com/40834245/54319746-9da88980-4610-11e9-994e-6fde2e5c1579.png)
Final State
![Screenshot from 2019-03-15 20-38-39](https://user-images.githubusercontent.com/40834245/54483521-5c1b1700-487a-11e9-99e5-09e9966be8c9.png)