Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] UI of Permissions page #13732

Merged
merged 21 commits into from
Apr 6, 2019

Conversation

fliptrail
Copy link
Contributor

@fliptrail fliptrail commented Mar 15, 2019

Closes #13700

This improves the UI of Permissions page. Now, all the roles are properly visible with horizontal scroll support for small screen devices. The text alignment and size of check boxes have been changed as well as size of edit icon. Also, now, the names of permissions are visible and the ID of permissions is hidden, (which earlier was redundant).

Initial State
Screenshot from 2019-03-14 04-21-23

Final State
Screenshot from 2019-03-15 20-38-39

@ggazzo
Copy link
Member

ggazzo commented Mar 15, 2019

hey man before commit try run ./node_modules/stylelint/bin/stylelint.js --fix "app/**/*.css"

@engelgabriel
Copy link
Member

The ID only looks redundant in English, but they are very helpful in other languages.

@fliptrail
Copy link
Contributor Author

@engelgabriel For a user in another language, he would be able to see Permission in his native language as well as the Permission in ID (english). I personally, think that it would be redundant. However if you suggest, I can push a commit to display the ID in a smaller font and a greyed out color. That would be more appealing to the user. The rest of my commits focus on displaying of all roles and horizontal scrolling on small devices.

@engelgabriel
Copy link
Member

Ok, let's try the following:

  • Alight the first column to the left and remove IDs, but remove keep it a single line, so it is easy to read.
  • Rotate the role names 90deg with transform: rotate(-90deg);
  • Add IDs back on a new LAST column

The result should be something similar to the "Browser compatibility" table at https://developer.mozilla.org/en-US/docs/Web/CSS/text-orientation#Browser_compatibility

image

@engelgabriel
Copy link
Member

The Permission ID in a smaller font and a greyed out color in monospace font underneath could look good too.

@engelgabriel engelgabriel modified the milestones: 1.1.0, 1.0.0 Mar 16, 2019
@fliptrail
Copy link
Contributor Author

Working on it.

@fliptrail
Copy link
Contributor Author

Screenshot from 2019-03-17 06-03-14
@engelgabriel Please review, did as suggested.

@engelgabriel
Copy link
Member

Thank you so much @fliptrail it is almost perfect. I have some suggestions to make it a bit better, but they are not required for us to merge this PR.

  1. The checkboxes should be in the vertical center of the line.
  2. Something is making the columns have different widths, they should all have the same width.
  3. Remove the black lines, as we don't use them anywhere on the project.
  4. Keep the role names also in a single line and remove the unnecessary edit icon.

@fliptrail
Copy link
Contributor Author

Edit icon is I guess necessary to show that roles can be edited.
I guess without black borders the table would look odd
Please give your reviews.

@fliptrail
Copy link
Contributor Author

I will try to put custom checkboxes.

@engelgabriel
Copy link
Member

I will try to put custom checkboxes.

I don't have a problem with the native checkboxes, keep them. Just fix the vertical alignment.

@ggazzo ggazzo added the ui/ux label Mar 18, 2019
@engelgabriel
Copy link
Member

Thank you so much @fliptrail
@ggazzo please merge this and let's do any minor improvements later.

@rodrigok rodrigok merged commit 8121c08 into RocketChat:develop Apr 6, 2019
wreiske added a commit to wreiske/Rocket.Chat that referenced this pull request Apr 7, 2019
… into emoji-upgrades

* 'emoji-upgrades' of https://github.com/wreiske/Rocket.Chat:
  Settings: disable reset button (RocketChat#14026)
  Settings: hiding  reset button for readonly fields (RocketChat#14025)
  [NEW] Add support to updatedSince parameter in emoji-custom.list and deprecated old endpoint (RocketChat#13510)
  [IMPROVE] Add permission to change other user profile avatar (RocketChat#13884)
  [IMPROVE] UI of Permissions page (RocketChat#13732)
  [NEW] Chatpal: Enable custom search parameters (RocketChat#13828) (RocketChat#13829)
  [FIX] Closing sidebar when room menu is clicked. (RocketChat#13842)
  [FIX] Check settings for name requirement before validating (RocketChat#14021)
  Fix debug logging not being enabled by the setting (RocketChat#13979)
  [FIX] Links and upload paths when running in a subdir (RocketChat#13982)
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The current UI of Permissions page is unsatisfactory
5 participants