Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Threads to Discussion #13782

Merged
merged 29 commits into from Mar 22, 2019
Merged

Rename Threads to Discussion #13782

merged 29 commits into from Mar 22, 2019

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Mar 19, 2019

We have decided that was better to delay our v1 release and get the Threads done properly than get the feature out the way it was initially implemented on the develop branch. We have "rebranded" our current implementation of Threads to Discussions (was it creates a new room type) and will implement Threads exactly the same way as Slack does.

In our vision there are 2 different use cases on how to break out of the main conversation: one very easy and organic, with a single click for small side talk, and other, much more structured, that creates a new conversation with its own life cycle.

We have tried to have a single solution for both, and as a result, no one was happy with it.
So we have given up on having a single approach for both use cases and will implement both: the Slack-like industry standard and our brand new one, called Discussions.

#13843

@ggazzo ggazzo added ui/ux feat: threads / discussions Threads and Discussions labels Mar 19, 2019
@ggazzo ggazzo requested a review from tassoevan March 19, 2019 03:01
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13782 March 19, 2019 03:02 Inactive
tassoevan
tassoevan previously approved these changes Mar 19, 2019
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-13782 March 20, 2019 05:53 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-13782 March 20, 2019 05:56 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-13782 March 21, 2019 17:09 Inactive
@ggazzo ggazzo changed the title FIX - Start a new Thread system message NEW - Move from Thread to Discussion Mar 21, 2019
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-13782 March 21, 2019 18:24 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-13782 March 21, 2019 18:29 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-13782 March 21, 2019 18:33 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-13782 March 21, 2019 19:14 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-13782 March 21, 2019 19:58 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-13782 March 21, 2019 20:01 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-13782 March 21, 2019 20:17 Inactive
@engelgabriel
Copy link
Member

We have decided that was better to delay our v1 release and get the Threads done properly than get the feature out the way it was initially implemented on the develop branch. We have "rebranded" our current implementation of Threads to Discussions (was it creates a new room type) and will implement Threads exactly the same way as Slack does.

In our vision there are 2 different use cases on how to break out of the main conversation: one very easy and organic, with a single click for small side talk, and other, much more structured, that creates a new conversation with its own life cycle.

We have tried to have a single solution for both, and as a result, no one was happy with it.
So we have given up on having a single approach for both use cases and will implement both: the Slack-like industry standard and our brand new one, called Discussions.

#13843

@engelgabriel engelgabriel added this to the 1.0.0 milestone Mar 21, 2019
@engelgabriel
Copy link
Member

#13644

@sampaiodiego sampaiodiego temporarily deployed to rocket-chat-pr-13782 March 22, 2019 14:20 Inactive
@sampaiodiego sampaiodiego temporarily deployed to rocket-chat-pr-13782 March 22, 2019 14:32 Inactive
Copy link
Member Author

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM <3

@sampaiodiego sampaiodiego changed the title NEW - Move from Thread to Discussion Rename Threads to Discussion Mar 22, 2019
@sampaiodiego sampaiodiego merged commit be18e18 into develop Mar 22, 2019
@sampaiodiego sampaiodiego deleted the threads-system-messages branch March 22, 2019 19:51
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants