[FEATURE] Rest API upload file returns message object #13821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knrt10
changed the title
There was a problem hiding this comment.
@knrt10 I think the description of the issue says to return the message object and not the upload object. 🤔
|
@MarcosSpessatto hmm, my bad. Let me fix this |
knrt10
changed the title
|
@MarcosSpessatto updated the PR. |
MarcosSpessatto
requested changes
Mar 22, 2019
app/api/server/v1/rooms.js
Outdated
| }); | ||
|
|
||
| return API.v1.success(); | ||
| return API.v1.success({ file: Messages.getMessageByFileIdAndUsername(fileData._id, this.userId) }); |
There was a problem hiding this comment.
Can you change file to message?
|
No problem, let me update tests |
|
@MarcosSpessatto tests updated, also a small fix was made when |
|
@knrt10 amazing. Thanks so much. 🥇 |
|
No problem, happy to contribute |
knrt10
changed the title
MarcosSpessatto
previously approved these changes
Mar 29, 2019
rodrigok
approved these changes
Oct 19, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13808
Docs PR
@sampaiodiego @tassoevan would you please review.