-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Rest API Endpoint to get pinned messages from a room #13864
Merged
sampaiodiego
merged 7 commits into
RocketChat:develop
from
thayannevls:api-endpoint-pinned-messages
Aug 20, 2019
Merged
[NEW] Rest API Endpoint to get pinned messages from a room #13864
sampaiodiego
merged 7 commits into
RocketChat:develop
from
thayannevls:api-endpoint-pinned-messages
Aug 20, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error doesn't look to be related to the changes that I made... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thayannevls I think we should verify if the user can access the room before find the messages, to do this we have a function(canAccessRoom
).
MarcosSpessatto
approved these changes
Aug 20, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13853
Documentation PR: https://github.com/RocketChat/docs/pull/1157
What I did: I created an endpoint similar to
chat.getDeletedMessages
using offset and count parameters, the endpoint will return the messages objects in an array and the offset, count, total field. See more in the documentation.