Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Rest API Endpoint to get pinned messages from a room #13864

Merged

Conversation

thayannevls
Copy link
Contributor

@thayannevls thayannevls commented Mar 23, 2019

Closes #13853

Documentation PR: https://github.com/RocketChat/docs/pull/1157

What I did: I created an endpoint similar to chat.getDeletedMessages using offset and count parameters, the endpoint will return the messages objects in an array and the offset, count, total field. See more in the documentation.

@thayannevls
Copy link
Contributor Author

The error doesn't look to be related to the changes that I made...

Copy link
Contributor

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thayannevls I think we should verify if the user can access the room before find the messages, to do this we have a function(canAccessRoom).

@rodrigok rodrigok added this to PRs in 1.1.0 Review May 10, 2019
@rodrigok rodrigok moved this from PRs to PRs 1.2.0 in 1.1.0 Review May 15, 2019
@rodrigok rodrigok modified the milestones: 1.1.0, 1.2.0 May 15, 2019
@rodrigok rodrigok removed this from PRs Next in 1.1.0 Review May 15, 2019
@engelgabriel engelgabriel modified the milestones: 1.2.0, 1.3.0 Jul 10, 2019
@sampaiodiego sampaiodiego modified the milestones: 1.3.0, 1.4.0 Jul 25, 2019
@sampaiodiego sampaiodiego merged commit af88653 into RocketChat:develop Aug 20, 2019
@sampaiodiego sampaiodiego mentioned this pull request Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RESTAPI: get pinned message ?
5 participants