Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Layout of livechat manager pages to new style #13900

Conversation

@ggazzo
Copy link
Member

commented Mar 25, 2019

image
image
image
image
image

renatobecker and others added 8 commits Mar 15, 2019
Merge branch 'develop' into replace-agents-select-by-auto-complete-se…
…arch

# Conflicts:
#	app/livechat/client/views/app/livechatCurrentChats.js
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into pr/1…
…3730-renatobecker-replace-agents-select-by-auto-complete-search

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13900 Mar 25, 2019 Inactive

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13900 Mar 26, 2019 Inactive

@ggazzo ggazzo requested a review from sampaiodiego Mar 26, 2019

@ggazzo ggazzo temporarily deployed to rocket-chat-pr-13900 Mar 26, 2019 Inactive

Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into pr/1…
…3730-renatobecker-replace-agents-select-by-auto-complete-search

@ggazzo ggazzo added this to the 1.2.0 milestone May 28, 2019

ggazzo added 2 commits May 29, 2019
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into pr/1…
…3730-renatobecker-replace-agents-select-by-auto-complete-search

@ggazzo ggazzo force-pushed the pr/13730-renatobecker-replace-agents-select-by-auto-complete-search branch from d2875d5 to 268227f May 29, 2019

@engelgabriel

This comment has been minimized.

Copy link
Member

commented May 29, 2019

@ggazzo can we move all the "Add New" buttons to the top?

@ggazzo

This comment has been minimized.

Copy link
Member Author

commented May 29, 2019

@ggazzo can we move all the "Add New" buttons to the top?

I could, but it's more expensive... today the header its autogenerated :/

@ggazzo ggazzo added the subj: ui/ux label May 29, 2019

@RocketChat RocketChat deleted a comment from codacy-bot May 29, 2019

@RocketChat RocketChat deleted a comment from codacy-bot May 29, 2019

@renatobecker

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

@ggazzo, after clicking 2X on the Load more button(Current Chats), the button disappears.
Did you notice that?

Screen Shot 2019-05-29 at 21 06 47

@ggazzo

This comment has been minimized.

Copy link
Member Author

commented May 30, 2019

@ggazzo, after clicking 2X on the Load more button(Current Chats), the button disappears.
Did you notice that?

Screen Shot 2019-05-29 at 21 06 47

If I'm not mistaken, the load more only appears IF we have something more to load... we could disable instead of hide... but its not a bug I think

@ggazzo ggazzo requested a review from renatobecker Jun 10, 2019

@renatobecker
Copy link
Contributor

left a comment

Everything is looking and working fine to me, but I noticed that the buttons are not displayed right on Livechat Appearance, look:

Screen Shot 2019-06-11 at 22 39 10

@renatobecker renatobecker removed the request for review from sampaiodiego Jun 21, 2019

@renatobecker renatobecker requested review from sampaiodiego and removed request for sampaiodiego Jun 21, 2019

@renatobecker renatobecker requested a review from Hudell Jun 21, 2019

@renatobecker renatobecker removed the request for review from Hudell Jun 21, 2019

@renatobecker renatobecker added this to In progress in Livechat Roadmap via automation Jun 21, 2019

fixed

Livechat Roadmap automation moved this from In progress to Reviewer approved Jun 21, 2019

@sampaiodiego sampaiodiego changed the title [IMPROVE] Current chats new table style (Livechat) [IMPROVE] Layout of livechat manager pages to new style Jun 21, 2019

@sampaiodiego sampaiodiego merged commit dd45652 into develop Jun 21, 2019

4 of 5 checks passed

ci/circleci: build-and-test/hold Your job is on hold on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test-with-oplog-mongo-3-2 Your tests passed on CircleCI!
Details
ci/circleci: test-with-oplog-mongo-4-0 Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

Livechat Roadmap automation moved this from Reviewer approved to Done Jun 21, 2019

@sampaiodiego sampaiodiego deleted the pr/13730-renatobecker-replace-agents-select-by-auto-complete-search branch Jun 21, 2019

@sampaiodiego sampaiodiego referenced this pull request Jun 28, 2019
Kailash0311 added a commit to WideChat/Rocket.Chat that referenced this pull request Jun 29, 2019
Service Account Subscription (#59)
* Service Account broadcast room callback added

* Service Account Callback completed

* CLI errors fixed

* [NEW] Service Account one-tap login complete

* Callbacks modified

* Service Accounts directory tab added

* [NEW] Service Accounts Login method

* Typo fixed

* CLI errors fixed

* CLI errors fixed

* [FIX] Anonymous chat read (RocketChat#14717)

* Prevent errors when allowing anonymous read

* getSingleMessage for anonymous users

* Fix register user when allow read and write anonymous is enabled

* Fix anonymous with sidebar extended as default

Co-authored-by: ubergeekzone <ubergeekzone@gmail.com>

* [New] Service Account directory feature

* CLI errors fixed

* UsernameExists meteor method fixed

* Sync commit

* [NEW] Add loading animation to webdav file picker (RocketChat#14759)

* [NEW] Service Account subscription method added

* [NEW] Service account subscription sidenav type

* changed mongo version for snap from 3.2.7 to 3.4.20 (RocketChat#14838)

* add _hidden for messages loaded by thread (RocketChat#14837)

* Regression: thread loading parent msg if is not loaded (RocketChat#14839)

* [IMPROVE] Layout of livechat manager pages to new style (RocketChat#13900)

* [FIX] Removes E2E action button, icon and banner when E2E is disabled. (RocketChat#14810)

* [IMPROVE] Adds link to download generated user data file (RocketChat#14175)

* [FIX] Error when using Download My Data or Export My Data (RocketChat#14645)

* [NEW] Custom User Status (RocketChat#13933)

Co-Authored-By: Tasso Evangelista <tasso@tassoevan.me>
Co-Authored-By: Guilherme Gazzo <guilhermegazzo@gmail.com>
Co-Authored-By: wreiske <wreiske@mieweb.com>

* Allow debugging of cached collections by name (RocketChat#14859)

* Regression: Allow debugging of cached collections by name (RocketChat#14862)

* Regression: Fix desktop notifications not being sent (RocketChat#14860)

* Broadcast Room name change handled

* Lint errors fixed

* getLoginToken method refactored

* Console statements removed

* Sidebar header permission modified

* Merge branch service-accounts

* Added service account directory search translation key

* Subscribers count added

* [NEW] Service Account sidenav type

* Synced with base branch
Kailash0311 added a commit to WideChat/Rocket.Chat that referenced this pull request Jul 2, 2019
Added get linked service accounts method (#60)
* [FIX] Load messages after disconnect and message box scroll missing (RocketChat#14668)

* Removing unnecesary federation configs (RocketChat#14674)

* [FIX] SAML login error. (RocketChat#14686)

* Bump version to 1.1.1

* Service Account broadcast room callback added

* Service Account Callback completed

* CLI errors fixed

* [NEW] Service Account one-tap login complete

* Callbacks modified

* Service Accounts directory tab added

* [NEW] Service Accounts Login method

* Typo fixed

* CLI errors fixed

* CLI errors fixed

* [FIX] Anonymous chat read (RocketChat#14717)

* Prevent errors when allowing anonymous read

* getSingleMessage for anonymous users

* Fix register user when allow read and write anonymous is enabled

* Fix anonymous with sidebar extended as default

Co-authored-by: ubergeekzone <ubergeekzone@gmail.com>

* [FIX] User Real Name being erased when not modified (RocketChat#14711)

* [FIX] User status information on User Info panel (RocketChat#14763)

* [FIX] Anonymous chat read (RocketChat#14717)

* Prevent errors when allowing anonymous read

* getSingleMessage for anonymous users

* Fix register user when allow read and write anonymous is enabled

* Fix anonymous with sidebar extended as default

Co-authored-by: ubergeekzone <ubergeekzone@gmail.com>

* Bump version to 1.1.2

* [New] Service Account directory feature

* CLI errors fixed

* UsernameExists meteor method fixed

* Sync commit

* [NEW] Add loading animation to webdav file picker (RocketChat#14759)

* [NEW] Service Account subscription method added

* changed mongo version for snap from 3.2.7 to 3.4.20 (RocketChat#14838)

* add _hidden for messages loaded by thread (RocketChat#14837)

* Regression: thread loading parent msg if is not loaded (RocketChat#14839)

* [IMPROVE] Layout of livechat manager pages to new style (RocketChat#13900)

* [FIX] Removes E2E action button, icon and banner when E2E is disabled. (RocketChat#14810)

* add _hidden for messages loaded by thread (RocketChat#14837)

* Regression: thread loading parent msg if is not loaded (RocketChat#14839)

* Bump version to 1.1.3

* [IMPROVE] Adds link to download generated user data file (RocketChat#14175)

* [FIX] Error when using Download My Data or Export My Data (RocketChat#14645)

* [NEW] Custom User Status (RocketChat#13933)

Co-Authored-By: Tasso Evangelista <tasso@tassoevan.me>
Co-Authored-By: Guilherme Gazzo <guilhermegazzo@gmail.com>
Co-Authored-By: wreiske <wreiske@mieweb.com>

* Bump version to 1.2.0-rc.0

* Allow debugging of cached collections by name (RocketChat#14859)

* Regression: Allow debugging of cached collections by name (RocketChat#14862)

* Regression: Fix desktop notifications not being sent (RocketChat#14860)

* Broadcast Room name change handled

* Lint errors fixed

* getLoginToken method refactored

* Console statements removed

* Sidebar header permission modified

* Merge branch service-accounts

* Added service account directory search translation key

* Subscribers count added

* [FIX] Custom status fixes (RocketChat#14853)

* Fixes for status message text presence issues
Added statusText to several api endpoints
Changed statusMessage to statusText since that is what it is called everywhere

* Fixed slash command for changing status

* Fixed the "name is required" issue

* Make sure the status is set blank if selecting a default status... we don't want an "online" status when someone is actually offline!

* Fixes display of custom status on the room header

* Changed the header of DM rooms to query the server for the user status text when it is not found on the internal collection

* Changed Custom Status methods to check if the user is logged in

* Improved code readability

* Fix getting status list before logging in

* Bump version to 1.2.0-rc.1

* [FIX] LinkedIn OAuth login (RocketChat#14887)

* [NEW] Show App bundles and its apps (RocketChat#14886)

* Bump version to 1.2.0-rc.2

* Bump version to 1.2.0

* Bump version to 1.3.0-develop

* [FIX] Not showing local app on App Details (RocketChat#14894)

* Unread counter added in popver

* Get linked service account method added
Kailash0311 added a commit to WideChat/Rocket.Chat that referenced this pull request Jul 2, 2019
Merged Upstream develop (#61)
* [FIX] Load messages after disconnect and message box scroll missing (RocketChat#14668)

* Removing unnecesary federation configs (RocketChat#14674)

* [FIX] SAML login error. (RocketChat#14686)

* Bump version to 1.1.1

* Service Account broadcast room callback added

* Service Account Callback completed

* CLI errors fixed

* [NEW] Service Account one-tap login complete

* Callbacks modified

* Service Accounts directory tab added

* [NEW] Service Accounts Login method

* Typo fixed

* CLI errors fixed

* CLI errors fixed

* [FIX] Anonymous chat read (RocketChat#14717)

* Prevent errors when allowing anonymous read

* getSingleMessage for anonymous users

* Fix register user when allow read and write anonymous is enabled

* Fix anonymous with sidebar extended as default

Co-authored-by: ubergeekzone <ubergeekzone@gmail.com>

* [FIX] User Real Name being erased when not modified (RocketChat#14711)

* [FIX] User status information on User Info panel (RocketChat#14763)

* [FIX] Anonymous chat read (RocketChat#14717)

* Prevent errors when allowing anonymous read

* getSingleMessage for anonymous users

* Fix register user when allow read and write anonymous is enabled

* Fix anonymous with sidebar extended as default

Co-authored-by: ubergeekzone <ubergeekzone@gmail.com>

* Bump version to 1.1.2

* [New] Service Account directory feature

* CLI errors fixed

* UsernameExists meteor method fixed

* Sync commit

* [NEW] Add loading animation to webdav file picker (RocketChat#14759)

* [NEW] Service Account subscription method added

* changed mongo version for snap from 3.2.7 to 3.4.20 (RocketChat#14838)

* add _hidden for messages loaded by thread (RocketChat#14837)

* Regression: thread loading parent msg if is not loaded (RocketChat#14839)

* [IMPROVE] Layout of livechat manager pages to new style (RocketChat#13900)

* [FIX] Removes E2E action button, icon and banner when E2E is disabled. (RocketChat#14810)

* add _hidden for messages loaded by thread (RocketChat#14837)

* Regression: thread loading parent msg if is not loaded (RocketChat#14839)

* Bump version to 1.1.3

* [IMPROVE] Adds link to download generated user data file (RocketChat#14175)

* [FIX] Error when using Download My Data or Export My Data (RocketChat#14645)

* [NEW] Custom User Status (RocketChat#13933)

Co-Authored-By: Tasso Evangelista <tasso@tassoevan.me>
Co-Authored-By: Guilherme Gazzo <guilhermegazzo@gmail.com>
Co-Authored-By: wreiske <wreiske@mieweb.com>

* Bump version to 1.2.0-rc.0

* Allow debugging of cached collections by name (RocketChat#14859)

* Regression: Allow debugging of cached collections by name (RocketChat#14862)

* Regression: Fix desktop notifications not being sent (RocketChat#14860)

* Broadcast Room name change handled

* Lint errors fixed

* getLoginToken method refactored

* Console statements removed

* Sidebar header permission modified

* Merge branch service-accounts

* Added service account directory search translation key

* Subscribers count added

* [FIX] Custom status fixes (RocketChat#14853)

* Fixes for status message text presence issues
Added statusText to several api endpoints
Changed statusMessage to statusText since that is what it is called everywhere

* Fixed slash command for changing status

* Fixed the "name is required" issue

* Make sure the status is set blank if selecting a default status... we don't want an "online" status when someone is actually offline!

* Fixes display of custom status on the room header

* Changed the header of DM rooms to query the server for the user status text when it is not found on the internal collection

* Changed Custom Status methods to check if the user is logged in

* Improved code readability

* Fix getting status list before logging in

* Bump version to 1.2.0-rc.1

* [FIX] LinkedIn OAuth login (RocketChat#14887)

* [NEW] Show App bundles and its apps (RocketChat#14886)

* Bump version to 1.2.0-rc.2

* Bump version to 1.2.0

* Bump version to 1.3.0-develop

* [FIX] Not showing local app on App Details (RocketChat#14894)

* Unread counter added in popver

* Get linked service account method added

* get cloud generated public key for marketplace licenses (RocketChat#14851)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.