Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] group name appears instead of the room id #14075

Merged
merged 5 commits into from
Apr 29, 2019
Merged

[Fix] group name appears instead of the room id #14075

merged 5 commits into from
Apr 29, 2019

Conversation

mohamedar97
Copy link
Contributor

@mohamedar97 mohamedar97 commented Apr 9, 2019 •
edited
Loading

Closes #14064

@mohamedar97 mohamedar97 changed the title Issue#14064 [Fix] group name appears instead of the room id Apr 9, 2019
sampaiodiego
sampaiodiego previously requested changes Apr 10, 2019
View reviewed changes
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for you contribution.. while this works for discussions, it might not work for regular rooms.

the correct way to get a room's name is using roomTypes.getRoomName ..

@mohamedar97
Copy link
Contributor Author

i think that fixes it?

@ggazzo
Copy link
Member

ggazzo commented Apr 17, 2019

@mohamedar97 could you fix the issue to complete the build? :)

@ggazzo ggazzo added this to the 1.0.2 milestone Apr 29, 2019
@ggazzo ggazzo dismissed sampaiodiego’s stale review April 29, 2019 16:56

[Fix] group name appears instead of the room id (#14075)

@ggazzo ggazzo merged commit 0ec2927 into RocketChat:develop Apr 29, 2019
rodrigok pushed a commit that referenced this pull request Apr 30, 2019
@mohamedar97 @rodrigok
[Fix] group name appears instead of the room id (#14075)
f3f7f34 
* removed quote option from message options

* modifications to show discussion name instead of the id when removing the user

* Revert "removed quote option from message options"

This reverts commit 2078abd.

* modifications for implementing

* liniting fixes
@rodrigok rodrigok mentioned this pull request Apr 30, 2019
Merged
@msisskin msisskin mentioned this pull request Jan 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

@sampaiodiego sampaiodiego sampaiodiego left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.2
Development

Successfully merging this pull request may close these issues.

[BUG] Discussion name is not displayed while removing a user from discussion
3 participants
@mohamedar97 @ggazzo @sampaiodiego