Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Updating a message from apps if keep history is on #14129

Merged
merged 2 commits into from
Apr 15, 2019

Conversation

sampaiodiego
Copy link
Member

Related to #14127

Updating a message from Apps is currently failing if Keep Per Message Editing History setting is true, because the model is calling Meteor.userId(), but it doesn't the needed context if being called from an app.

@sampaiodiego sampaiodiego added this to the 1.0.0 milestone Apr 12, 2019
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-14129 April 12, 2019 19:10 Inactive
Copy link
Member

@d-gubert d-gubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sampaiodiego sampaiodiego merged commit e092090 into develop Apr 15, 2019
@sampaiodiego sampaiodiego deleted the fix-update-message-by-apps-keep-history branch April 15, 2019 13:03
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants