Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Cursor position set to beginning when editing a message #14245

Merged
merged 2 commits into from
Apr 25, 2019
Merged

Regression: Cursor position set to beginning when editing a message #14245

merged 2 commits into from
Apr 25, 2019

Conversation

rodrigok
Copy link
Member

@rodrigok rodrigok commented Apr 24, 2019 •
edited
Loading

Closes #14239

@rodrigok rodrigok added this to the 1.0.0 milestone Apr 24, 2019
@rodrigok rodrigok requested a review from ggazzo April 24, 2019 22:06
@geekgonecrazy
Copy link
Member

When did we set to the beginning? It used to always be at the end. I actually thought it defaulting to the beginning was a bug. 🙈

@tassoevan
Copy link
Contributor

@geekgonecrazy Actually the PR title is the regression it tries to solve 😬

@geekgonecrazy
Copy link
Member

😌 good! the 0 or -1 seems kinda odd. Seemed like setting to beginning.

@rodrigok rodrigok merged commit a11939e into develop Apr 25, 2019
@rodrigok rodrigok deleted the regression-edit-cursor-position branch April 25, 2019 12:22
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo Awaiting requested review from ggazzo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Arrow up to edit the last message set the cursor position to the beginning of the message instead of the end
3 participants
@rodrigok @geekgonecrazy @tassoevan