Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some federation tweaks #14441

Closed
wants to merge 11 commits into from
Closed

Added some federation tweaks #14441

wants to merge 11 commits into from

Conversation

alansikora
Copy link
Contributor

  • Made sure development environment does not use production federation hub;
  • Organized some files;
  • Added federation statistics;

Copy link
Contributor

@geekgonecrazy geekgonecrazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like overall something went nuts reformatting. 😬

app/statistics/server/functions/get.js Outdated Show resolved Hide resolved
@alansikora
Copy link
Contributor Author

@geekgonecrazy you can check again

geekgonecrazy
geekgonecrazy previously approved these changes May 13, 2019
@geekgonecrazy
Copy link
Contributor

@sampaiodiego what do you want to do about these linting errors? It is griping about:

20:1  error  There should be no empty line within import group  import/order`

Seems to only happen if a single import on its own line. If there are two in a row it stops

@alansikora
Copy link
Contributor Author

@geekgonecrazy that does not happen locally

@sampaiodiego
Copy link
Member

@geekgonecrazy there are few import groups that cannot have empty lines between those imports.

Usually they'll be external and internal imports, they need to separate by an empty line, but cannot have empty lines within the group, like:

import _ from 'underscore';
import { Meteor } from 'meteor/meteor';

import { anything } from './internal/path';
import { other } from './internal/other';

Co-Authored-By: Diego Sampaio <chinello@gmail.com>
@geekgonecrazy
Copy link
Contributor

Is this coming in 1.1.0 or being delayed to 1.2.0?

@sampaiodiego sampaiodiego added this to the 1.2.0 milestone May 21, 2019
@sampaiodiego
Copy link
Member

delayed to 1.2.0

@alansikora
Copy link
Contributor Author

@sampaiodiego I will close this one, you can reopen if you wish, but this is not relevant anymore.

@alansikora alansikora closed this Jul 16, 2019
@geekgonecrazy geekgonecrazy deleted the federation-tweaks branch July 16, 2019 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants