-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added some federation tweaks #14441
Added some federation tweaks #14441
Conversation
alansikora
commented
May 9, 2019
- Made sure development environment does not use production federation hub;
- Organized some files;
- Added federation statistics;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like overall something went nuts reformatting. 😬
2321367
to
36df59b
Compare
@geekgonecrazy you can check again |
@sampaiodiego what do you want to do about these linting errors? It is griping about:
Seems to only happen if a single import on its own line. If there are two in a row it stops |
be1fd31
to
08894e6
Compare
@geekgonecrazy that does not happen locally |
@geekgonecrazy there are few import groups that cannot have empty lines between those imports. Usually they'll be external and internal imports, they need to separate by an empty line, but cannot have empty lines within the group, like: import _ from 'underscore';
import { Meteor } from 'meteor/meteor';
import { anything } from './internal/path';
import { other } from './internal/other'; |
Co-Authored-By: Diego Sampaio <chinello@gmail.com>
Is this coming in 1.1.0 or being delayed to 1.2.0? |
delayed to 1.2.0 |
@sampaiodiego I will close this one, you can reopen if you wish, but this is not relevant anymore. |