Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVE] jump to selected message on open thread #14460

Merged
merged 5 commits into from May 14, 2019
Merged

[IMPROVE] jump to selected message on open thread #14460

merged 5 commits into from May 14, 2019

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented May 10, 2019

No description provided.

@ggazzo ggazzo requested a review from tassoevan May 10, 2019 16:47
@ggazzo ggazzo added this to the 1.0.4 milestone May 10, 2019
@ggazzo ggazzo added the ui/ux label May 10, 2019
tassoevan
tassoevan requested changes May 10, 2019
View reviewed changes
Copy link
Contributor

@tassoevan tassoevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think renaming jump as jumpTo would be more informative.

app/threads/client/flextab/thread.js Outdated Show resolved Hide resolved
app/threads/client/flextab/thread.js Outdated Show resolved Hide resolved
ggazzo and others added 3 commits May 10, 2019 16:21
@ggazzo @tassoevan
Update app/threads/client/flextab/thread.js
173a7dd 
Co-Authored-By: Tasso Evangelista <tasso@tassoevan.me>
@ggazzo @tassoevan
Update app/threads/client/flextab/thread.js
6c3a531 
Co-Authored-By: Tasso Evangelista <tasso@tassoevan.me>
@ggazzo
Merge branch 'develop' into scroll-thread
a40736c
@ggazzo ggazzo requested a review from tassoevan May 14, 2019 18:32
@ggazzo ggazzo merged commit 59ab8b6 into develop May 14, 2019
@ggazzo ggazzo deleted the scroll-thread branch May 14, 2019 21:27
@tassoevan tassoevan modified the milestones: 1.0.4, 1.1.0 May 20, 2019
@rodrigok rodrigok added this to Done in 1.1.0 Review May 20, 2019
@sampaiodiego sampaiodiego mentioned this pull request May 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tassoevan tassoevan tassoevan approved these changes

Assignees
No one assigned
Labels
ui/ux
Projects
No open projects
1.1.0 Review
  
Done
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ggazzo @tassoevan