Fix thumbs up emoji shortname #14581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggazzo
approved these changes
May 22, 2019
wreiske
added a commit
to wreiske/Rocket.Chat
that referenced
this pull request
May 27, 2019
… into new-reports-ui * 'new-reports-ui' of https://github.com/wreiske/Rocket.Chat: (97 commits) LingoHub Update 🚀 (RocketChat#14643) [FIX] Role name spacing on Permissions page (RocketChat#14625) [FIX] Avatar images on old Livechat client (RocketChat#14590) [FIX] Inject code at the end of <head> tag (RocketChat#14623) [FIX] Mailer breaking if user doesn't have an email address (RocketChat#14614) Ci improvements (RocketChat#14600) [FIX] E2E messages not decrypting in message threads (RocketChat#14580) Fix: emoji render performance for alias (RocketChat#14593) [FIX] Send replyTo for livechat offline messages (RocketChat#14568) Federation i18n message changes (RocketChat#14595) [REGRESSION] Fix Slack bridge channel owner on channel creation (RocketChat#14565) Fix thumbs up emoji shortname (RocketChat#14581) Fix broken logo url in app.json (RocketChat#14572) Add digitalocean button to readme (RocketChat#14583) Fix: Add emoji shortnames to emoji's list (RocketChat#14576) [IMPROVE] Message rendering time (RocketChat#14252) [IMPROVE] Change user presence events to Meteor Streams (RocketChat#14488) Removed unnecessary DDP unblocks (RocketChat#13641) [FIX] Downloading files when running in sub directory (RocketChat#14485) [FIX] Broken layout when sidebar is open on IE/Edge (RocketChat#14567) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shortname for thumbs up emoji
:+1:was not working because its+sign is escaped on theshortnamesstring, where it tries to find usingindexOf..for the fix I needed to copy the whole function and add the same escape method (
replace(/[+]/g, '\\$&')) pior theindexOf