Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Handle missing emojis #14641

Merged
merged 4 commits into from May 28, 2019
Merged

Regression: Handle missing emojis #14641

merged 4 commits into from May 28, 2019

Conversation

sampaiodiego
Copy link
Member

After EmojiOne upgrade, some emojis are missing and not being properly handled if one of the missing emojis were on Recent category.

With this PR those missing emojis are now skipped and removed from recent category

@sampaiodiego sampaiodiego added this to the 1.1.0 milestone May 27, 2019
@sampaiodiego sampaiodiego force-pushed the handle-missing-emojis branch 2 times, most recently from 370db2f to a487ac0 Compare May 27, 2019 20:18
app/emoji/lib/rocketchat.js Outdated Show resolved Hide resolved
@sampaiodiego sampaiodiego merged commit 4474fc0 into develop May 28, 2019
@sampaiodiego sampaiodiego deleted the handle-missing-emojis branch May 28, 2019 01:16
@sampaiodiego sampaiodiego mentioned this pull request May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants