Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW] Add Mobex to the list of SMS service providers #14655

Merged
merged 30 commits into from
Aug 20, 2019
Merged

[NEW] Add Mobex to the list of SMS service providers #14655

merged 30 commits into from
Aug 20, 2019

Conversation

zolbayars
Copy link
Contributor

Hi,

This will add Mobex as an SMS service provider.

Screenshot from 2019-05-28 10-57-54 (1)

zolbayars and others added 24 commits January 31, 2019 21:44
@zolbayars
Added Jasmin menu in SMS section
705d726
@zolbayars
Added description and type to some Jasmin settings
49050f1
@zolbayars
Added main Jasmin operation and edited some descriptions
366adfc
@zolbayars
Removed Jasmin port desc
e8093b5
@zolbayars
Added some debug msg
7f0d1e2
@zolbayars
Added jasmin service to registration
cd72ee0
@zolbayars
Added some debug msg and stripped username from tags
c48fcfb
@zolbayars
Removed tabs and newline from literal
b909b6d
@zolbayars
Stripped plus sign from to number
e6c2269
@zolbayars
Removed tabs and newline from literal
9227d75
@zolbayars
Log to the sms receiving part
e4edf14
@zolbayars
Added get on sms receiver
4caf8ce
@zolbayars
Added jasmin ack on controller
6a71ec8
@zolbayars
Jasmin debug
759b992
@zolbayars
Jasmin debug
5a6fe86
@zolbayars
Jasmin configuration for receiving
1a7a6bc
@zolbayars
Jasmin configuration for receiving
d549836
@zolbayars
Jasmin configuration for receiving
894d96e
@zolbayars
Edits according to lint check
4a408d8
@zolbayars
More edits according to lint check
a0c8c83
@zolbayars
Jasmin return corrected
bcf097b
@zolbayars
v1.1 changes
9a917f7
@zolbayars
Add Mobex to the list of SMS providers
d4d9d7e
@zolbayars
Add Mobex to the SMS service providers - linting
14ae50e
@zolbayars
Copy link
Contributor Author

Don't really know why it's falling on the first title should be Runtime Environment. It's exactly Runtime Environment on a browser.

1) [Administration] [Admin View] info: the first title should be Runtime Environment: Uncaught Error: An element could not be located on the page using the given search parameters (".content h3:nth-of-type(3)"). at moveToObject() - index.js:307:3

@zolbayars
Copy link
Contributor Author

All checks have passed. Gonna wait till someone review this 😄

@sampaiodiego sampaiodiego added this to the 1.2.0 milestone May 30, 2019
@engelgabriel engelgabriel modified the milestones: 1.2.0, 1.3.0 Jul 10, 2019
@sampaiodiego sampaiodiego modified the milestones: 1.3.0, 1.4.0 Jul 25, 2019
@sampaiodiego sampaiodiego added this to In progress in 2.0.0 via automation Aug 20, 2019
2.0.0 automation moved this from In progress to Reviewer approved Aug 20, 2019
@sampaiodiego sampaiodiego merged commit f14baef into RocketChat:develop Aug 20, 2019
2.0.0 automation moved this from Reviewer approved to Done Aug 20, 2019
@sampaiodiego sampaiodiego mentioned this pull request Sep 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

@renatobecker-zz renatobecker-zz Awaiting requested review from renatobecker-zz

Assignees
No one assigned
Labels
None yet
Projects
No open projects
2.0.0
  
Done
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zolbayars @sampaiodiego @engelgabriel