Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Property "permission" in slash commands of custom apps (#14739) #14741

Merged
merged 3 commits into from
Sep 20, 2019
Merged

[FIX] Property "permission" in slash commands of custom apps (#14739) #14741

merged 3 commits into from
Sep 20, 2019

Conversation

ifantom
Copy link
Contributor

@ifantom ifantom commented Jun 4, 2019

Closes #14739

@CLAassistant
Copy link

CLAassistant commented Jun 4, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@engelgabriel engelgabriel added this to the 1.3.0 milestone Jul 12, 2019
@d-gubert d-gubert modified the milestones: 1.3.0, 1.4.0 Jul 22, 2019
@sampaiodiego sampaiodiego modified the milestones: 2.0.0, 2.1.0 Sep 6, 2019
d-gubert
d-gubert approved these changes Sep 20, 2019
View reviewed changes
Copy link
Member

@d-gubert d-gubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the contribution @ifantom!! 🤗

@sampaiodiego sampaiodiego merged commit 0ba28fc into RocketChat:develop Sep 20, 2019
@sampaiodiego sampaiodiego mentioned this pull request Sep 27, 2019
Merged
@ifantom ifantom deleted the apps-slash-commands-permission branch October 4, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-gubert d-gubert d-gubert approved these changes

@rodrigok rodrigok Awaiting requested review from rodrigok

Assignees

@d-gubert d-gubert

Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

Property "permission" in slash commands of custom apps
5 participants
@ifantom @CLAassistant @d-gubert @engelgabriel @sampaiodiego