Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] SAML login by giving displayName priority over userName for fullName #14880

Merged
merged 1 commit into from
Jul 2, 2019
Merged

[FIX] SAML login by giving displayName priority over userName for fullName #14880

merged 1 commit into from
Jul 2, 2019

Conversation

pkolmann
Copy link
Contributor

Closes #14876

@pkolmann
Copy link
Contributor Author

@Hudell can you please approve this minor change

@Hudell Hudell added this to the 1.3.0 milestone Jun 27, 2019
@sampaiodiego sampaiodiego changed the title [FIX] Give DisplayName priority over userName for FullName [FIX] SAML login by giving displayName priority over userName for fullName Jul 2, 2019
@sampaiodiego sampaiodiego merged commit a3fb62f into RocketChat:develop Jul 2, 2019
@sampaiodiego sampaiodiego mentioned this pull request Aug 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hudell Hudell Hudell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Bug introduced with Improvement #12891
3 participants
@pkolmann @Hudell @sampaiodiego