Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract canSendMessage function #14909

Merged
merged 7 commits into from
Jul 2, 2019
Merged

Extract canSendMessage function #14909

merged 7 commits into from
Jul 2, 2019

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Jul 1, 2019

No description provided.

@ggazzo ggazzo requested a review from sampaiodiego July 1, 2019 17:57
sampaiodiego
sampaiodiego requested changes Jul 2, 2019
View reviewed changes
app/authorization/server/functions/canSendMessage.js Outdated Show resolved Hide resolved
app/authorization/server/functions/canSendMessage.js Outdated Show resolved Hide resolved
app/authorization/server/functions/canSendMessage.js Outdated

const subscriptionProjection = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change to:

const subscriptionOptions = {
	projection: {
		blocked: 1,
		blocker: 1,
	},
};

app/models/server/raw/Rooms.js Outdated Show resolved Hide resolved
ggazzo and others added 5 commits July 2, 2019 12:11
@ggazzo @sampaiodiego
Update app/authorization/server/functions/canSendMessage.js
8efb9bf 
Co-Authored-By: Diego Sampaio <chinello@gmail.com>
@ggazzo @sampaiodiego
Update app/models/server/raw/Rooms.js
1e022f3 
Co-Authored-By: Diego Sampaio <chinello@gmail.com>
@ggazzo @sampaiodiego
Update app/authorization/server/functions/canSendMessage.js
68dc6d7 
Co-Authored-By: Diego Sampaio <chinello@gmail.com>
@ggazzo
Update canSendMessage.js
e7d4bc6
@ggazzo
Update Rooms.js
9c03593
@ggazzo ggazzo requested a review from d-gubert July 2, 2019 19:14
@sampaiodiego sampaiodiego changed the title [NEW] canSendMessage async Extract canSendMessage function Jul 2, 2019
@sampaiodiego sampaiodiego merged commit 3ce57f4 into develop Jul 2, 2019
@sampaiodiego sampaiodiego deleted the canSendMessage branch July 2, 2019 19:28
@sampaiodiego sampaiodiego mentioned this pull request Aug 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

@d-gubert d-gubert Awaiting requested review from d-gubert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ggazzo @sampaiodiego