[FIX] Webdav crash #14918
Merged
[FIX] Webdav crash #14918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
probably also a fix for my problem: #14900 |
|
@MarcosSpessatto can the webdav fix be in the 1.3.0 release? |
sampaiodiego
approved these changes
Aug 20, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14900
For some reasons the
statusproperty is inside theerror.responsehttps://github.com/perry-mitchell/webdav-client/blob/master/source/interface/stat.js#L8 🤷♂️Related to #14243 (comment)
Also for some reasons all exceptions coming from the
webdavnpm package, seems return axios response inside the error object instead the original error itself. Due to that an error is caused by Meteor when trying to parse the response content with the EJSON. EJSON is trying to parse the axios response that is a circular JSON. Maybe related to it: perry-mitchell/webdav-client#159Maybe related to #13355
Maybe related to #13191