Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW: Apps enable after app installed #15202

Merged
merged 3 commits into from
Aug 20, 2019
Merged

Conversation

d-gubert
Copy link
Member

With this PR, apps will be automatically enabled after install, and a different text will be shown if the app is in the INVALID_SETTINGS_DISABLED state.

image

image

@d-gubert d-gubert added this to the 2.0.0 milestone Aug 19, 2019
@d-gubert d-gubert added this to In progress in 2.0.0 via automation Aug 19, 2019
@reetp
Copy link

reetp commented Aug 19, 2019

Please don't do that.
I don't want apps enabled thank you.

@d-gubert
Copy link
Member Author

Hey @reetp ! So, the current behavior is, when you click Install in an app, said app is installed but remains disabled - which requires you to manually enable it.

The change this PR introduces is that, when you click Install in an app, said app is installed AND is automatically enabled - no further interaction is required.

Do you think this change is actually undesirable? We've found this new behavior to be simpler for the user. Considering you are willingly installing an app, you'd probably think you can start using it right away

@wreiske
Copy link
Contributor

wreiske commented Aug 19, 2019

I prefer it this way... I can't tell you how many times I've gone in and had an enabled app actual disable itself or after restart have to manually re-enable all my apps. +1

@geekgonecrazy
Copy link
Member

geekgonecrazy commented Aug 19, 2019

@reetp to be clear.. this is to enable individual apps after the user has chosen to install them.

The apps engine has already always been on by default. That in its self is not a privacy issue. Users can choose to side load an app. Or they can opt-in to use the marketplace. They are never forced to do so. If they chose to never install an app the engine will sit there unused with no issues.

We will never automatically opt you into the marketplace. We want to encourage the marketplace so you can discover apps.. but never force it. It is opt-in.

Thanks

2.0.0 automation moved this from In progress to Reviewer approved Aug 19, 2019
@sampaiodiego sampaiodiego merged commit 429b1ee into develop Aug 20, 2019
2.0.0 automation moved this from Reviewer approved to Done Aug 20, 2019
@sampaiodiego sampaiodiego deleted the apps-enable-after-install branch August 20, 2019 13:32
@geekgonecrazy geekgonecrazy changed the title NEW: Apps enable after install NEW: Apps enable after app installed Aug 20, 2019
@sampaiodiego sampaiodiego mentioned this pull request Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
2.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants