[NEW] Provide site-url to outgoing integrations #15238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graywolf336
approved these changes
Aug 29, 2019
|
since this PR is approved, do you have a plan, when to release this? |
sampaiodiego
changed the title
Merged
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When notifying foreign systems about a message, it can be desirable that the remote system responds back. In order to do that, it needs to know from which system the orginal message was issued.
Implementation
In order to do that, the site-url shall be propagated to the webhook implementation which can then pass it on.
Of course, there are other options (such as setting the referrer in the HTTP-request), but sometimes it's handy to explicitly be able to handle it.